-
-
Notifications
You must be signed in to change notification settings - Fork 87
Fix TypeScript typechecking not working #1002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vixalien
wants to merge
6
commits into
main
Choose a base branch
from
wip/vixalien/fix-workbench-ambient
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
36aff2c
chore: upgrade gi-types
vixalien 4ef4e57
chore: fix template index path
vixalien 3834927
chore: add the correct types to workbench global ambient
vixalien 53596e3
Merge branch 'main' into wip/vixalien/fix-workbench-ambient
sonnyp 98b5e75
cli: Do not attempt to run TypeScript files
sonnyp 4562b8d
f
sonnyp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule gi-types
deleted from
396fe1
Submodule gi-types
added at
e70b49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,50 +1,17 @@ | ||
// import Adw from "gi://Adw"; | ||
// import Gtk from "gi://Gtk?version=4.0"; | ||
// import GObject from "gi://GObject"; | ||
|
||
// additional type declarations for GJS | ||
/// <reference path="../template/gi-types/index.d.ts" /> | ||
|
||
// additional GJS log utils | ||
declare function print(...args: any[]): void; | ||
declare function log(...args: any[]): void; | ||
|
||
// GJS pkg global | ||
declare const pkg: { | ||
version: string; | ||
name: string; | ||
}; | ||
import Adw from "gi://Adw"; | ||
import Gtk from "gi://Gtk?version=4.0"; | ||
// import GObject from "gi://GObject"; | ||
|
||
// old GJS global imports | ||
// used like: imports.format.printf("..."); | ||
declare module imports { | ||
// format import | ||
const format: { | ||
format(this: String, ...args: any[]): string; | ||
printf(fmt: string, ...args: any[]): string; | ||
vprintf(fmt: string, args: any[]): string; | ||
declare global { | ||
const workbench: { | ||
window: Adw.ApplicationWindow; | ||
application: Adw.Application; | ||
builder: Gtk.Builder; | ||
template: string; | ||
resolve(path: string): string; | ||
preview(object: Gtk.Widget): void; | ||
// build(params: Record<string, Function | GObject.Object>): void; | ||
}; | ||
sonnyp marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
// gettext import | ||
declare module "gettext" { | ||
export function gettext(id: string): string; | ||
export function ngettext( | ||
singular: string, | ||
plural: string, | ||
n: number, | ||
): string; | ||
} | ||
|
||
// TODO: uncomment correct typings after we switch to `ts-for-gir` | ||
// declare const workbench: { | ||
// window: Adw.ApplicationWindow; | ||
// application: Adw.Application; | ||
// builder: Gtk.Builder; | ||
// template: string; | ||
// resolve(path: string): string; | ||
// preview(object: Gtk.Widget): void; | ||
// build(params: Record<string, Function | GObject.Object>): void; | ||
// }; | ||
|
||
// global workbench object | ||
declare const workbench: any; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.