-
-
Notifications
You must be signed in to change notification settings - Fork 186
Feat/bottom bar into components library #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several significant changes focused on refactoring and modernizing the public session and welcome feature components in the frontend. The main updates include migrating session-related pages to use new design library templates, cleaning up and removing legacy and unused welcome components, and improving code consistency and maintainability.
Session and Authentication Flow Refactor:
SigninPage,SignupPage,ForgotPage,ResetPage,AccountActivationPage) that leverage up-to-date design library templates for a more unified and maintainable UI (frontend/src/components/areas/public/features/session/pages/). [1] [2] [3] [4] [5]SessionPagecomponent that organizes all authentication routes under a single base template, streamlining the routing and layout logic (frontend/src/components/areas/public/features/session/pages/session-page.tsx).Sessioncomponent to handle authentication via token and redirect users appropriately after login (frontend/src/components/areas/public/features/session/components/session.tsx).Storybook and Template Enhancements:
SignupSigninBasetemplate and a corresponding Storybook decorator for consistent session-related page layouts (frontend/.storybook/decorators/withPublicTemplate.tsx). [1] [2]Cleanup and Removal of Legacy/Unused Components:
BottomSectionDialog,Info,OurStack,cubes.js,clientlist.js, and their associated styles, reducing technical debt and improving code clarity (frontend/src/components/areas/public/features/welcome/components/). [1] [2] [3] [4] [5] [6]Minor Improvements and Fixes:
frontend/src/components/areas/private/components/session/cookie-policy.tsx).searchUserSuccessaction to use the correct property name (datainstead ofuser) for consistency with the rest of the codebase (frontend/src/actions/loginActions.js).frontend/.storybook/main.js).These changes modernize the session and welcome flows, improve maintainability, and remove outdated code, setting the foundation for further improvements in the user authentication and onboarding experience.