-
Notifications
You must be signed in to change notification settings - Fork 155
chore: retract v1 #1325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: retract v1 #1325
Conversation
I plan to merge it and then tag it with v1.68.0
WalkthroughRemoves almost the entire AST subsystem (types, values, selections, nodes, input handling, index, helpers), the parser and importer, the normalization framework and most normalization passes and tests; updates module metadata with a go.mod retract + deprecation comments; removes many Makefile targets and adjusts CI workflows and README text. Changes
Sequence Diagram(s)(omitted) — changes are wholesale removals and do not introduce a new control-flow feature suitable for a sequence diagram. Estimated code review effort🎯 5 (Critical) | ⏱️ ~120+ minutes Reason: Very large, heterogeneous deletions across core packages removing many exported types/functions and tests; requires thorough API-compatibility, dependency impact analysis, and migration verification. Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
go.mod (2)
1-1
: Good deprecation notice; also announce in docs/release notes.The comment is fine, but it won’t surface on pkg.go.dev. Add a deprecation note to the v1.68.0 release notes and README to maximize visibility and migration clarity.
6-11
: Deduplicate retractions and clarify rationale
- Remove standalone v1.0.0; the range [v1.0.0, v1.67.4] already covers all v1 tags.
- Add inline comments explaining why each version/range is retracted (e.g. migration to v2 path).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
go.mod
(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-29T09:35:47.969Z
Learnt from: ysmolski
PR: wundergraph/graphql-go-tools#1282
File: v2/pkg/engine/plan/visitor.go:5-5
Timestamp: 2025-08-29T09:35:47.969Z
Learning: The wundergraph/graphql-go-tools project does not support Go versions < 1.23, so compatibility concerns for features available in Go 1.21+ (like cmp.Or) should not be raised.
Applied to files:
go.mod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/dummy-ci.yaml (1)
1-15
: Clarify whether this minimal CI approach is intentional and temporary.This workflow intentionally does nothing (
echo Nothing to do
) and only runs on meta-file changes (.gitignore, LICENSE, README.md). Given that this PR removes most of the codebase as part of a v1 retraction, this appears to be a pragmatic placeholder during the deprecation phase.However, ensure:
- This is explicitly intended by the team (not an accidental skipping of real tests)
- Other workflows (mentioned in the PR summary: execution.yml, v2.yml) provide sufficient coverage for the remaining codebase
- The approach is temporary or clearly documented for future maintainers
As an operational note: Consider adding a more descriptive workflow name, explicit
if
conditions, or documentation in your CI/CD process indicating this is a temporary measure during the v1 retraction. This prevents future contributors from being confused about why PR checks pass with no validation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/dummy-ci.yaml
(1 hunks).github/workflows/execution.yml
(1 hunks).github/workflows/v2.yml
(2 hunks)
✅ Files skipped from review due to trivial changes (2)
- .github/workflows/execution.yml
- .github/workflows/v2.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Build and test (go 1.25 / windows-latest)
- GitHub Check: Build and test (go 1.25 / ubuntu-latest)
- GitHub Check: Build and test (go 1.25 / windows-latest)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add 1.67.5 to retracted
Thanks. I did it and also tidied the go.mod |
pkg/**
andMakefile
were removed.I kept go.mod for the release. We will remove it later.
Dummy CI was added for non-code changes to files in the root.
Changes in linter config will trigger v2 and executions workflows.
I plan to merge it and then tag it with v1.67.5
Summary by CodeRabbit
Chores
Documentation
Refactor
Tests
CI