Skip to content

fix: auto icons override default icons #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: auto icons override default icons #1616

wants to merge 1 commit into from
+1 −1

Conversation

omerfardemir
Copy link

just removed return statement in line 35.

wxt/packages/auto-icons/src/index.ts

Line 35 in 31071bd

return wxt.logger.warn(

Manual Testing

  1. have default icons in the public folder public/icon/*
  2. install auto icons
  3. add a icon to <src>/assets/icon.png
  4. run npm run dev

This PR closes #1592

@omerfardemir omerfardemir requested a review from Timeraa as a code owner April 25, 2025 23:29
@netlify Netlify
Copy link

netlify bot commented Apr 25, 2025 •
edited
Loading

✅ Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 6946fe1
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/680c1ac51c812500085f3014
😎 Deploy Preview https://deploy-preview-1616--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timeraa Timeraa Awaiting requested review from Timeraa Timeraa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto icons doesnt override default icons
1 participant
@omerfardemir