-
-
Notifications
You must be signed in to change notification settings - Fork 311
Update environment-variables.md with info about env.DEV #1630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small structural changes, then we're good to merge. Thanks for opening a PR!
}, | ||
}); | ||
``` | ||
|
||
WXT can't load your `.env` files until after the config file has been loaded. So by using the function syntax for `manifest`, it defers creating the object until after the `.env` files are loaded into the process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move your changes to be below this line? I think having this explaination beneath the original example is better, since your new example isn't about .env
file variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, done!
Co-authored-by: Aaron <aaronklinker1@gmail.com>
Co-authored-by: Aaron <aaronklinker1@gmail.com>
I'm not sure if this is a bug or intended but if it's not a bug and the docs just need to updated, hopefully this is correct. I also removed the deprecated chromeApi key.