fix: Allow passing strings instead of enums #1646
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
aklinker1
commented
May 2, 2025
| @@ -13209,7 +13209,7 @@ export namespace Browser { | |||
| /** | |||
| * A list of request types. Requests that cannot match any of the types will be filtered out. | |||
| */ | |||
| types?: ResourceType[] | undefined; | |||
| types?: (ResourceType | `${ResourceType}`)[] | undefined; | |||
There was a problem hiding this comment.
Downside to this approach: ResourceType is actually a string literal union here. There's another enum further down that is named ResourceType, so this type was also modified.
This might be fine now, but as @types/chrome is updated, this approach might cause problems in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Addresses concerns mentioned here:
Warning
Not sure if I want to actually merge this PR or not... The regex approach isn't very clean, and it makes mistakes. I think it would make more sense to update
@types/chromedirectly to allow using string litterals in specific cases, like they already do.Manual Testing
See new type test