feat: Make injectScript return the created script element #1838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
The patch series in which each PR builds on top of the previous one: #1761, #1762, #1763, #1838 (you are here), #1765.
In case some of the changes are rejected, I will rebase the subsequent PRs on top of main.
Overview
injectScript
now returns the created script element. It can be used to e.g. send messages to the script in the form of custom events. The script can add an event listener for them viadocument.currentScript
. An example of bidirectional communication:I made
injectScript
return an object ({ script }
) for future extensibility, in particular for returning the result value of the script.Manual Testing
Create the files in the example above, add the following to wxt.config.ts, observe the event being logged in the console.
Related Issue
N/A