Skip to content

speed improvements and a bug fix #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 51 commits into from
Sep 10, 2025
Merged

speed improvements and a bug fix #8

merged 51 commits into from
Sep 10, 2025

Conversation

@petar
Copy link
Collaborator

@petar petar commented Jun 5, 2025 •
edited
Loading

  • this PR includes fix race condition in driver closure #7
  • introduces mpool: a sync.Pool cache for *bytes.Buffers used in Messages
  • adds stats for mpool
  • avoids goroutine creation when server is processing calls in sequence
  • fixes an old bug forgetting to safeSend a reply in error cases
  • new implementation of xdrReadN resulting in massive speed gains

@petar petar requested a review from stanford-scs June 9, 2025 01:15
@petar petar changed the title avoid goroutine when processing server calls in sequence speed improvements and a bug fix Jun 9, 2025
petar added 24 commits July 27, 2025 14:05
@petar
avoid bytes.Buffer allocation
5bef373
@petar
put msgpool behind an interface
32e3fb6
@petar
remove init from arena
fb2a5d7
@petar
swap in message pool
6cacee5
@petar
prealloc 200 bytes for msg buffer
1651d87
@petar
rm prealloc
99a8c97
@petar
fix bug in prealloc
32f59fe
@petar
wipe prealloc
5b687d9
@petar
add rmsgChanPool
151017a
@petar
Revert "add rmsgChanPool"
a421d30 
This reverts commit 151017a.
@petar
test doMsg par = 1
ac068bb
@petar
remove latency meters from driver
17d19dc
@petar
switch to arena
df6ca7c
@petar
turn off receive parallelism
da8dc1b
@petar
receive par 3; reset objects on returning to pool as well
b50289e
@petar
remove default msg pool allocator
ec0acb0
@petar
improve doMsg
8dcb515
@petar
compat with old interface
7051480
@petar
intro call pool
b2fbdfa
@petar
use stack alloc for xdrGet32/64
a7173c3
@petar
stack alloc xdrReadPad
7ca143f
@petar
cleanup
8b5c5af
@petar
tunable defalt max message size
330db3a
@petar
fix bug in xdrReadN
b3774c1
@petar petar merged commit c3c75e1 into master Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stanford-scs stanford-scs Awaiting requested review from stanford-scs

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@petar