Augment vue instead of @vue/runtime-core
#197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinaskav
added a commit
to vu-sa/vusa.lt
that referenced
this pull request
Jan 24, 2025
Created pull request to permanently fix issue: xiCO2k/laravel-vue-i18n#197
|
Thanks for that. |
|
I'm having the same problem, could this change be published as a new release please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @xiCO2k, thanks for developing a great package!
As already pulled in other packages, e.g. primefaces/primevue#6199, inertiajs/inertia#2099, it seems that the augmentations with custom properties should use the
'vue'module instead of'@vue/runtime-core'. Also, it is documented on the Vue.js page.For me it caused an issue with my Inertia app dev experience, where my
$pageproperty had lost its type in Vue SFC template. It seems it has been resolved with this commit (at least for me).Cheers!