Skip to content

fix: add tail-case handling for elementwise_add_f16x8_pack_kernel to … #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 25, 2025
Merged

fix: add tail-case handling for elementwise_add_f16x8_pack_kernel to … #380

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d498904
fix: add tail-case handling for elementwise_add_f16x8_pack_kernel to …
lhycms Aug 23, 2025
6a84e3e
Rename nx to idx
lhycms Aug 24, 2025
ec82df5
Fix bug: nx -> idx
lhycms Aug 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions kernels/elementwise/elementwise.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,10 @@ __global__ void elementwise_add_f16x8_pack_kernel(half *a, half *b, half *c,
// reinterpret as float4 and store 128 bits in 1 memory issue.
if ((idx + 7) < N) {
LDST128BITS(c[idx]) = LDST128BITS(pack_c[0]);
} else {
for (int i=0; nx+i<N; i++) {
c[idx+i] = __hadd(a[idx+i], b[idx+i]);
}
}
}

Expand Down