Initial support for Altivec #1151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serge-sans-paille
force-pushed
the
feature/tentative-altivec-support-ex
branch
9 times, most recently
from
4db420e to
831a79b
Compare
Only supports altivec/vmx with vsx extension, tested on both little and big endian architectures. Several operations could be improved, but this should pass CI. Notable changes: - document the fact that slide_left and slide_right are unreliable on big endian architecture - gcc chokes on force_inline for altivec, so dismiss it - some common code were making assumption of conversion between batch_bool registers and batch_registers that proved to be difficult for altivec/vmx type system, make the conversion explicit.
Add support for ceil, floor, round, trunc, fma and fms.
serge-sans-paille
force-pushed
the
feature/tentative-altivec-support-ex
branch
from
831a79b to
077dc8e
Compare
|
@serge-sans-paille Velox depends heavily on xsimd for performance. I'm am also interested in supporting the ppc64le architecture in Velox. Is your plan to expand this work to Velox, or is there another reason you need VSX support in xsimd? |
|
@Jenkins-J VSX support was added because I had a genuine interest in VMX/VSX and I was curious about how that would translate to xsimd. I'm glad to see it would benefit to Velox! |
JohanMabille
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only supports altivec with vxs extension, tested on both little and big endian architectures.
Notable changes:
document the fact that slide_left and slide_right are unreliable on big endian architecture
gcc chokes on force_inline for altivec, so dismiss it
some common code were making assumption of conversion between batch_bool registers and batch_registers that proved to be difficult for altivec type system, make the conversion explicit.