Update FrenchLayout.js #59
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
French layout unneccesary repeating letters removal.
Collaborator
|
@SamKhachatryan I'll review this tomorrow, looks fine on a quick check. I'm just going for a Xmas eve dinner and just want to run it to confirm it's all good 🤞 |
Author
|
Sure, take your time, thanks a lot. |
Author
|
Btw seems like I made a mistake, changing inside |
Collaborator
|
@SamKhachatryan I'm back at work and have more availability but in discuss to your comment on the last about I'm been waiting for the commit and now that I'm back I thought I'd touch base with you to try get this moving. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
French layout unneccesary repeating letters removal.
P.S. this package is deeply integrated in our current ecosystem, and we don't plan to change it. I kindly ask to approve the PR if it seems okay, when you'll have time. Also we can discuss maintainance rules if you don't plan to work on this anymore.