feat(TableColumnSetup): support sortable columns #2908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
requested review from
artemmufazalov,
astandrik and
adameat
as code owners
artemmufazalov
requested changes
Sep 22, 2025
| items={columnsToSelect} | ||
| showStatus | ||
| onUpdate={handleTableColumnsSetupChange} | ||
| sortable={false} |
There was a problem hiding this comment.
Hook useSelectedColumns is not used here, you should change the logic inside PartitionsTableColumnSetup to make it work
Raubzeug
force-pushed
the
table-column-setup-sortable
branch
from
e0f74f4 to
a30dd1e
Compare
artemmufazalov
requested changes
Sep 23, 2025
| const columns = useGetPartitionsColumns(selectedConsumer); | ||
|
|
||
| const [columns, columnsIdsForSelector] = useGetPartitionsColumns(selectedConsumer); | ||
| const {columnsToShow, columnsToSelect, setColumns} = useSelectedColumns( |
There was a problem hiding this comment.
Columns are not reordered
There was a problem hiding this comment.
Sorry, I simply didn't redeploy stand. For now it's done and columns are reordering as expected.
|
If I change columns order when no consumer is selected, I have only 7 columns instead of 15 when I select consumer |
|
Also if I change selected columns when no consumer is selected, all consumer specific columns become not selected |
Fixed, stand redeployed |
artemmufazalov
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2522
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: ✅
Current: 85.40 MB | Main: 85.40 MB
Diff: +0.28 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information