Skip to content

Extract transaction-related code from Private Cache #22610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 11, 2025
Merged

Extract transaction-related code from Private Cache #22610

merged 5 commits into from
Aug 11, 2025

Conversation

kunga
Copy link
Member

@kunga kunga commented Aug 8, 2025 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Extract transaction-related code from Private Cache to TPageCollectionReadEnv, so it's only implement cache coherency protocol and store some additional page collection data (like cache mode and sticky pages).

@kunga kunga changed the title cf1935a: Extract transaction-related code from Private Cache Extract transaction-related code from Private Cache Aug 8, 2025
@kunga kunga self-assigned this Aug 8, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2025 •
edited
Loading

⚪ 2025-08-08 15:08:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2f56627 has started.
⚪ 2025-08-08 15:08:06 UTC Artifacts will be uploaded here
⚪ 2025-08-08 15:11:43 UTC ya make is running...
🟡 2025-08-08 16:32:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37601 34816 0 5 2751 29

⚪ 2025-08-08 16:36:03 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-08-08 16:51:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
692 (only retried tests) 617 0 2 50 23

⚪ 2025-08-08 16:51:15 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-08-08 17:06:38 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
684 (only retried tests) 609 0 2 50 23

🟢 2025-08-08 17:06:47 UTC Build successful.
🟢 2025-08-08 17:07:09 UTC ydbd size 2.2 GiB changed* by +5.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b9d5713 merge: 2f56627 diff diff %
ydbd size 2 414 891 744 Bytes 2 414 897 080 Bytes +5.2 KiB +0.000%
ydbd stripped size 504 955 784 Bytes 504 955 144 Bytes -640 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2025

🟢 2025-08-08 15:09:07 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2025 •
edited
Loading

🟢 2025-08-11 08:09:06 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2025 •
edited
Loading

⚪ 2025-08-08 15:09:47 UTC Pre-commit check linux-x86_64-release-asan for 2f56627 has started.
⚪ 2025-08-08 15:10:00 UTC Artifacts will be uploaded here
⚪ 2025-08-08 15:13:26 UTC ya make is running...
🟡 2025-08-08 17:05:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15051 14633 0 90 303 25

🟢 2025-08-08 17:06:50 UTC Build successful.
🟢 2025-08-08 17:07:20 UTC ydbd size 4.0 GiB changed* by -19.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: b9d5713 merge: 2f56627 diff diff %
ydbd size 4 248 572 408 Bytes 4 248 552 384 Bytes -19.6 KiB -0.000%
ydbd stripped size 1 470 133 848 Bytes 1 470 126 712 Bytes -7.0 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 11, 2025 •
edited
Loading

⚪ 2025-08-11 08:05:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for c6a7e77 has started.
⚪ 2025-08-11 08:06:10 UTC Artifacts will be uploaded here
⚫ 2025-08-11 08:07:12 UTC Check cancelled

@kunga kunga marked this pull request as ready for review August 11, 2025 08:07
@kunga kunga requested a review from a team as a code owner August 11, 2025 08:07
@kunga kunga requested a review from lex007in August 11, 2025 08:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 11, 2025 •
edited
Loading

⚪ 2025-08-11 08:08:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for fb7c9ca has started.
⚪ 2025-08-11 08:08:30 UTC Artifacts will be uploaded here
⚪ 2025-08-11 08:11:57 UTC ya make is running...
🔴 2025-08-11 08:17:31 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 11, 2025 •
edited
Loading

⚪ 2025-08-11 08:09:52 UTC Pre-commit check linux-x86_64-release-asan for fb7c9ca has started.
⚪ 2025-08-11 08:10:16 UTC Artifacts will be uploaded here
⚪ 2025-08-11 08:14:13 UTC ya make is running...
🔴 2025-08-11 08:17:52 UTC Build failed, see the logs. Also see fail summary

@kunga kunga mentioned this pull request Aug 11, 2025
Open
32 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 11, 2025 •
edited
Loading

⚪ 2025-08-11 10:24:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 496ffb8 has started.
⚪ 2025-08-11 10:25:04 UTC Artifacts will be uploaded here
⚪ 2025-08-11 10:28:23 UTC ya make is running...
🟡 2025-08-11 11:48:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37606 34798 0 1 2765 42

⚪ 2025-08-11 11:51:49 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-08-11 12:07:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
911 (only retried tests) 834 0 0 50 27

🟢 2025-08-11 12:07:59 UTC Build successful.
🟢 2025-08-11 12:08:19 UTC ydbd size 2.2 GiB changed* by +12.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 15cba86 merge: 496ffb8 diff diff %
ydbd size 2 415 153 208 Bytes 2 415 165 760 Bytes +12.3 KiB +0.001%
ydbd stripped size 505 012 296 Bytes 505 011 464 Bytes -832 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 11, 2025 •
edited
Loading

⚪ 2025-08-11 10:24:58 UTC Pre-commit check linux-x86_64-release-asan for 496ffb8 has started.
⚪ 2025-08-11 10:25:13 UTC Artifacts will be uploaded here
⚪ 2025-08-11 10:28:35 UTC ya make is running...
🟡 2025-08-11 12:22:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15056 14633 0 141 255 27

🟢 2025-08-11 12:24:01 UTC Build successful.
🟢 2025-08-11 12:24:28 UTC ydbd size 4.0 GiB changed* by +17.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 15cba86 merge: 496ffb8 diff diff %
ydbd size 4 249 059 800 Bytes 4 249 077 656 Bytes +17.4 KiB +0.000%
ydbd stripped size 1 470 307 192 Bytes 1 470 304 792 Bytes -2.3 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kunga kunga merged commit 3bfe700 into ydb-platform:main Aug 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lex007in lex007in lex007in approved these changes

Assignees

@kunga kunga

Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunga @lex007in