Skip to content

Change the default logging level to WARN from EMERG for CLI commands that support multiple verbosity levels #22612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 11, 2025
Merged

Change the default logging level to WARN from EMERG for CLI commands that support multiple verbosity levels #22612

merged 3 commits into from
Aug 11, 2025

Conversation

pnv1
Copy link
Collaborator

@pnv1 pnv1 commented Aug 8, 2025

Changelog entry

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

@pnv1 pnv1 requested a review from a team as a code owner August 8, 2025 15:23
@pnv1 pnv1 added the area/cli CLI related issues label Aug 8, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2025 •
edited
Loading

⚪ 2025-08-08 15:24:02 UTC Pre-commit check linux-x86_64-release-asan for 36e123a has started.
⚪ 2025-08-08 15:24:17 UTC Artifacts will be uploaded here
⚪ 2025-08-08 15:27:49 UTC ya make is running...
⚫ 2025-08-08 16:53:50 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2025 •
edited
Loading

⚪ 2025-08-08 15:25:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 36e123a has started.
⚪ 2025-08-08 15:25:04 UTC Artifacts will be uploaded here
⚪ 2025-08-08 15:28:29 UTC ya make is running...
🟡 2025-08-08 16:47:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37561 34771 0 8 2751 31

⚪ 2025-08-08 16:50:44 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-08-08 16:54:02 UTC ydbd size 2.2 GiB changed* by +232.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b9d5713 merge: 36e123a diff diff %
ydbd size 2 414 891 744 Bytes 2 415 130 056 Bytes +232.7 KiB +0.010%
ydbd stripped size 504 955 784 Bytes 505 007 080 Bytes +50.1 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-08-08 16:54:04 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2025

🟢 2025-08-08 15:26:31 UTC The validation of the Pull Request description is successful.

Gazizonoki
Gazizonoki reviewed Aug 8, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2025 •
edited
Loading

⚪ 2025-08-08 16:54:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for c84eb47 has started.
⚪ 2025-08-08 16:55:22 UTC Artifacts will be uploaded here
⚪ 2025-08-08 16:59:14 UTC ya make is running...
🟡 2025-08-08 18:15:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37561 34740 0 10 2780 31

⚪ 2025-08-08 18:19:02 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-08-08 18:33:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1246 (only retried tests) 1114 0 5 103 24

⚪ 2025-08-08 18:34:09 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-08-08 18:48:32 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
898 (only retried tests) 794 0 3 77 24

🟢 2025-08-08 18:48:43 UTC Build successful.
🟢 2025-08-08 18:49:03 UTC ydbd size 2.2 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 07b141b merge: c84eb47 diff diff %
ydbd size 2 415 130 056 Bytes 2 415 130 056 Bytes 0 Bytes 0.000%
ydbd stripped size 505 007 080 Bytes 505 007 080 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Gazizonoki
Gazizonoki previously approved these changes Aug 8, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2025 •
edited
Loading

⚪ 2025-08-08 16:55:55 UTC Pre-commit check linux-x86_64-release-asan for c84eb47 has started.
⚪ 2025-08-08 16:56:01 UTC Artifacts will be uploaded here
⚪ 2025-08-08 16:59:22 UTC ya make is running...
🟡 2025-08-08 18:46:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15013 14573 0 118 301 21

🟢 2025-08-08 18:48:17 UTC Build successful.
🟢 2025-08-08 18:48:45 UTC ydbd size 4.0 GiB changed* by -4.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 07b141b merge: c84eb47 diff diff %
ydbd size 4 249 042 952 Bytes 4 249 038 528 Bytes -4.3 KiB -0.000%
ydbd stripped size 1 470 291 864 Bytes 1 470 287 640 Bytes -4.1 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pnv1 pnv1 enabled auto-merge (squash) August 8, 2025 16:59
@pnv1 pnv1 added the rebase-and-check Rebase PR with the current base branch and check label Aug 8, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Aug 8, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2025 •
edited
Loading

⚪ 2025-08-08 19:29:04 UTC Pre-commit check linux-x86_64-release-asan for 0acc99f has started.
⚪ 2025-08-08 19:29:24 UTC Artifacts will be uploaded here
⚪ 2025-08-08 19:33:10 UTC ya make is running...
🟡 2025-08-08 21:16:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15013 14606 0 95 292 20

🟢 2025-08-08 21:17:47 UTC Build successful.
🟢 2025-08-08 21:18:14 UTC ydbd size 4.0 GiB changed* by -320 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: f98be89 merge: 0acc99f diff diff %
ydbd size 4 248 999 968 Bytes 4 248 999 648 Bytes -320 Bytes -0.000%
ydbd stripped size 1 470 282 904 Bytes 1 470 282 776 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2025 •
edited
Loading

⚪ 2025-08-08 19:29:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0acc99f has started.
⚪ 2025-08-08 19:29:59 UTC Artifacts will be uploaded here
⚪ 2025-08-08 19:33:47 UTC ya make is running...
🟡 2025-08-08 20:47:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37559 34767 0 12 2751 29

⚪ 2025-08-08 20:50:25 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-08-08 21:07:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
901 (only retried tests) 817 0 2 58 24

⚪ 2025-08-08 21:07:26 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-08-08 21:22:01 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
678 (only retried tests) 600 0 4 50 24

🟢 2025-08-08 21:22:10 UTC Build successful.
🟢 2025-08-08 21:22:34 UTC ydbd size 2.2 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: f98be89 merge: 0acc99f diff diff %
ydbd size 2 415 122 304 Bytes 2 415 122 304 Bytes 0 Bytes 0.000%
ydbd stripped size 505 007 080 Bytes 505 007 080 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pnv1 pnv1 force-pushed the change-cli-default-logging-level branch from fc417cf to d47693b Compare August 11, 2025 08:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 11, 2025 •
edited
Loading

⚪ 2025-08-11 08:36:13 UTC Pre-commit check linux-x86_64-release-asan for 80aa521 has started.
⚪ 2025-08-11 08:36:17 UTC Artifacts will be uploaded here
⚪ 2025-08-11 08:39:36 UTC ya make is running...
🟡 2025-08-11 11:00:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15019 14668 0 86 245 20

🟢 2025-08-11 11:01:45 UTC Build successful.
🟢 2025-08-11 11:02:13 UTC ydbd size 4.0 GiB changed* by -336 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 8b7713d merge: 80aa521 diff diff %
ydbd size 4 249 113 320 Bytes 4 249 112 984 Bytes -336 Bytes -0.000%
ydbd stripped size 1 470 318 904 Bytes 1 470 318 776 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 11, 2025 •
edited
Loading

⚪ 2025-08-11 08:37:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for 80aa521 has started.
⚪ 2025-08-11 08:37:45 UTC Artifacts will be uploaded here
⚪ 2025-08-11 08:41:00 UTC ya make is running...
🟡 2025-08-11 10:21:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37567 34761 0 1 2767 38

⚪ 2025-08-11 10:25:13 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-08-11 10:40:18 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1073 (only retried tests) 999 0 0 50 24

🟢 2025-08-11 10:40:29 UTC Build successful.
🟢 2025-08-11 10:40:49 UTC ydbd size 2.2 GiB changed* by +48.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e900a77 merge: 80aa521 diff diff %
ydbd size 2 415 135 776 Bytes 2 415 185 272 Bytes +48.3 KiB +0.002%
ydbd stripped size 505 009 256 Bytes 505 017 672 Bytes +8.2 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pnv1 pnv1 merged commit 09574cc into ydb-platform:main Aug 11, 2025
11 checks passed
@pnv1 pnv1 deleted the change-cli-default-logging-level branch August 11, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gazizonoki Gazizonoki Gazizonoki approved these changes

Assignees
No one assigned
Labels
area/cli CLI related issues not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pnv1 @Gazizonoki