Skip to content

The order of the keys at the start of the partition #26110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2025
Merged

The order of the keys at the start of the partition #26110

merged 1 commit into from
Oct 2, 2025

Conversation

Alek5andr-Kotov
Copy link
Collaborator

@Alek5andr-Kotov Alek5andr-Kotov commented Sep 30, 2025 •
edited
Loading

Changelog entry

Issue #26050

The sorting order has changed. Keys with the suffix ? are at the end of the list. Predicate lastKey.getCount() <= candidate.getCount() doesn't make sense.

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner September 30, 2025 14:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2025 •
edited
Loading

🟢 2025-10-01 15:55:20 UTC The validation of the Pull Request description is successful.

This was referenced Sep 30, 2025
Closed
Merged
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2025 •
edited
Loading

⚪ 2025-09-30 15:09:15 UTC Pre-commit check linux-x86_64-release-asan for 04506ab has started.
⚪ 2025-09-30 15:09:18 UTC Artifacts will be uploaded here
🔴 2025-09-30 15:11:26 UTC Graph compare failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2025 •
edited
Loading

⚪ 2025-09-30 15:32:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for 04506ab has started.
⚪ 2025-09-30 15:32:23 UTC Artifacts will be uploaded here
🔴 2025-09-30 15:34:24 UTC Graph compare failed, see the logs.

@Alek5andr-Kotov Alek5andr-Kotov added the rebase-and-check Rebase PR with the current base branch and check label Oct 1, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Oct 1, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2025 •
edited
Loading

⚪ 2025-10-01 08:31:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7e9f5f1 has started.
⚪ 2025-10-01 08:32:40 UTC Artifacts will be uploaded here
🔴 2025-10-01 08:34:45 UTC Graph compare failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2025 •
edited
Loading

⚪ 2025-10-01 09:00:03 UTC Pre-commit check linux-x86_64-release-asan for 7e9f5f1 has started.
⚪ 2025-10-01 09:00:22 UTC Artifacts will be uploaded here
🔴 2025-10-01 09:02:27 UTC Graph compare failed, see the logs.

@Alek5andr-Kotov Alek5andr-Kotov force-pushed the LOGBROKER-9982 branch 2 times, most recently from b24712b to 728c319 Compare October 1, 2025 13:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2025 •
edited
Loading

⚪ 2025-10-01 13:04:13 UTC Pre-commit check linux-x86_64-release-asan for 1714edb has started.
⚪ 2025-10-01 13:04:28 UTC Artifacts will be uploaded here
🔴 2025-10-01 13:06:26 UTC Graph compare failed, see the logs.

@Alek5andr-Kotov Alek5andr-Kotov enabled auto-merge (squash) October 1, 2025 13:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2025 •
edited
Loading

⚪ 2025-10-01 13:21:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8b66b64 has started.
⚪ 2025-10-01 13:22:46 UTC Artifacts will be uploaded here
⚪ 2025-10-01 13:26:48 UTC ya make is running...
🟡 2025-10-01 15:13:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30957 29442 0 3 1481 31

⚪ 2025-10-01 15:13:33 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-10-01 15:23:09 UTC ydbd size 2.2 GiB changed* by +106.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b300d8e merge: 8b66b64 diff diff %
ydbd size 2 397 762 480 Bytes 2 397 871 560 Bytes +106.5 KiB +0.005%
ydbd stripped size 512 645 928 Bytes 512 657 000 Bytes +10.8 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-10-01 15:23:12 UTC Check cancelled

@Alek5andr-Kotov Alek5andr-Kotov added the rebase-and-check Rebase PR with the current base branch and check label Oct 1, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Oct 1, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2025 •
edited
Loading

⚪ 2025-10-01 15:29:12 UTC Pre-commit check linux-x86_64-release-asan for 3e1df1e has started.
⚪ 2025-10-01 15:29:49 UTC Artifacts will be uploaded here
⚪ 2025-10-01 15:35:04 UTC ya make is running...
🟡 2025-10-01 17:31:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15400 14950 0 139 284 27

🟢 2025-10-01 17:31:59 UTC Build successful.
🟢 2025-10-01 17:32:22 UTC ydbd size 3.7 GiB changed* by +11.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: eccbf4f merge: 3e1df1e diff diff %
ydbd size 3 988 388 944 Bytes 3 988 400 984 Bytes +11.8 KiB +0.000%
ydbd stripped size 1 486 514 976 Bytes 1 486 518 432 Bytes +3.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2025 •
edited
Loading

⚪ 2025-10-01 15:44:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3e1df1e has started.
⚪ 2025-10-01 15:44:54 UTC Artifacts will be uploaded here
⚪ 2025-10-01 15:48:24 UTC ya make is running...
🟡 2025-10-01 17:00:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30957 29447 0 4 1480 26

⚪ 2025-10-01 17:01:06 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-10-01 17:18:49 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
454 (only retried tests) 322 0 0 109 23

🟢 2025-10-01 17:19:07 UTC Build successful.
🟢 2025-10-01 17:21:33 UTC ydbd size 2.2 GiB changed* by +4.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: df38aca merge: 3e1df1e diff diff %
ydbd size 2 398 041 440 Bytes 2 398 045 536 Bytes +4.0 KiB +0.000%
ydbd stripped size 512 663 400 Bytes 512 664 616 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

This was referenced Oct 1, 2025
Merged
Merged
@Alek5andr-Kotov Alek5andr-Kotov removed the request for review from a-serebryanskiy October 2, 2025 07:49
@Alek5andr-Kotov Alek5andr-Kotov added the rebase-and-check Rebase PR with the current base branch and check label Oct 2, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Oct 2, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2025 •
edited
Loading

⚪ 2025-10-02 07:54:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for b8c5544 has started.
⚪ 2025-10-02 07:55:04 UTC Artifacts will be uploaded here
⚪ 2025-10-02 07:58:31 UTC ya make is running...
🟡 2025-10-02 09:08:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30966 29453 0 3 1480 30

⚪ 2025-10-02 09:08:45 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-10-02 09:27:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
452 (only retried tests) 318 0 1 109 24

⚪ 2025-10-02 09:27:33 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-10-02 09:42:52 UTC Some tests failed, follow the links below.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
369 (only retried tests) 235 0 1 109 24

🟢 2025-10-02 09:42:55 UTC Build successful.
🟢 2025-10-02 09:43:12 UTC ydbd size 2.2 GiB changed* by +4.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c8360ce merge: b8c5544 diff diff %
ydbd size 2 397 248 328 Bytes 2 397 252 416 Bytes +4.0 KiB +0.000%
ydbd stripped size 512 553 896 Bytes 512 555 112 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2025 •
edited
Loading

⚪ 2025-10-02 07:55:17 UTC Pre-commit check linux-x86_64-release-asan for b8c5544 has started.
⚪ 2025-10-02 07:55:32 UTC Artifacts will be uploaded here
⚪ 2025-10-02 07:59:01 UTC ya make is running...
🟡 2025-10-02 09:59:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15401 14982 0 144 246 29

🟢 2025-10-02 09:59:58 UTC Build successful.
🟢 2025-10-02 10:00:20 UTC ydbd size 3.7 GiB changed* by +10.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c8360ce merge: b8c5544 diff diff %
ydbd size 3 987 006 920 Bytes 3 987 018 016 Bytes +10.8 KiB +0.000%
ydbd stripped size 1 486 150 720 Bytes 1 486 153 920 Bytes +3.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Alek5andr-Kotov Alek5andr-Kotov added the rebase-and-check Rebase PR with the current base branch and check label Oct 2, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Oct 2, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2025 •
edited
Loading

⚪ 2025-10-02 13:41:32 UTC Pre-commit check linux-x86_64-release-asan for d9d7e05 has started.
⚪ 2025-10-02 13:41:36 UTC Artifacts will be uploaded here
⚪ 2025-10-02 13:45:12 UTC ya make is running...
⚫ 2025-10-02 14:23:03 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2025 •
edited
Loading

⚪ 2025-10-02 13:56:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for d9d7e05 has started.
⚪ 2025-10-02 13:56:15 UTC Artifacts will be uploaded here
⚪ 2025-10-02 14:00:00 UTC ya make is running...
⚫ 2025-10-02 14:23:02 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2025 •
edited
Loading

⚪ 2025-10-02 14:24:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0d45e77 has started.
⚪ 2025-10-02 14:24:12 UTC Artifacts will be uploaded here
⚪ 2025-10-02 14:27:42 UTC ya make is running...
🟡 2025-10-02 16:09:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30985 29475 0 2 1480 28

⚪ 2025-10-02 16:09:34 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-10-02 16:26:58 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
442 (only retried tests) 309 0 0 109 24

🟢 2025-10-02 16:27:01 UTC Build successful.
🟢 2025-10-02 16:27:19 UTC ydbd size 2.2 GiB changed* by +88.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a40a3ad merge: 0d45e77 diff diff %
ydbd size 2 399 148 776 Bytes 2 399 239 008 Bytes +88.1 KiB +0.004%
ydbd stripped size 512 906 600 Bytes 512 929 480 Bytes +22.3 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2025 •
edited
Loading

⚪ 2025-10-02 14:36:07 UTC Pre-commit check linux-x86_64-release-asan for 0d45e77 has started.
⚪ 2025-10-02 14:36:47 UTC Artifacts will be uploaded here
⚪ 2025-10-02 14:41:12 UTC ya make is running...
🟡 2025-10-02 17:16:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15419 14826 0 241 325 27

🟢 2025-10-02 17:16:16 UTC Build successful.
🟢 2025-10-02 17:16:39 UTC ydbd size 3.7 GiB changed* by -369.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9ef3ece merge: 0d45e77 diff diff %
ydbd size 3 991 960 576 Bytes 3 991 582 688 Bytes -369.0 KiB -0.009%
ydbd stripped size 1 487 869 536 Bytes 1 487 928 832 Bytes +57.9 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Alek5andr-Kotov Alek5andr-Kotov merged commit e5dfb94 into ydb-platform:main Oct 2, 2025
11 checks passed
maVovk pushed a commit to maVovk/ydb that referenced this pull request Oct 6, 2025
@Alek5andr-Kotov @maVovk
The order of the keys at the start of the partition (ydb-platform#26110)
c826171
@serbel324 serbel324 mentioned this pull request Oct 6, 2025
Closed
neyrox pushed a commit to neyrox/ydb that referenced this pull request Oct 7, 2025
@Alek5andr-Kotov @neyrox
The order of the keys at the start of the partition (ydb-platform#26110)
c54f9bf
@serbel324 serbel324 mentioned this pull request Oct 9, 2025
Merged
neyrox pushed a commit to neyrox/ydb that referenced this pull request Oct 10, 2025
@Alek5andr-Kotov @neyrox
The order of the keys at the start of the partition (ydb-platform#26110)
242d7ec
@serbel324 serbel324 mentioned this pull request Oct 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexnick88 alexnick88 alexnick88 approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Alek5andr-Kotov @alexnick88