Skip to content

Conversation

asmyasnikov
Copy link
Member

@asmyasnikov asmyasnikov commented Sep 30, 2025

Changelog entry

Related issue: #26022

Changelog category

  • Bugfix

Description for reviewers

...

@asmyasnikov asmyasnikov self-assigned this Sep 30, 2025
@asmyasnikov asmyasnikov added area/queryprocessor Query processor issues and requests local-ydb labels Sep 30, 2025
Copy link

github-actions bot commented Sep 30, 2025

🟢 2025-09-30 20:18:41 UTC The validation of the Pull Request description is successful.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the index_auto_choose_mode configuration setting from the local YDB test configuration when the PostgreSQL compatibility experiment is enabled. The change simplifies the test setup by removing what appears to be an experimental configuration flag.

  • Removes index_auto_choose_mode = 'max_used_prefix' from table service config
  • Maintains other PostgreSQL compatibility settings (AST cache, temp tables, PG types, PG syntax)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

github-actions bot commented Sep 30, 2025

2025-09-30 20:07:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for a27f9a6 has started.
2025-09-30 20:08:17 UTC Artifacts will be uploaded here
2025-09-30 20:11:44 UTC ya make is running...
2025-09-30 20:16:09 UTC Check cancelled

@asmyasnikov asmyasnikov enabled auto-merge (squash) September 30, 2025 20:07
Copy link

github-actions bot commented Sep 30, 2025

2025-09-30 20:07:54 UTC Pre-commit check linux-x86_64-release-asan for a27f9a6 has started.
2025-09-30 20:08:07 UTC Artifacts will be uploaded here
2025-09-30 20:10:59 UTC ya make is running...
2025-09-30 20:16:10 UTC Check cancelled

@asmyasnikov asmyasnikov changed the title Dropped index_auto_choose_mode flag from local-ydb config with env YDB_EXPERIMENTAL_P=1 Dropped index_auto_choose_mode flag from local-ydb config with env YDB_EXPERIMENTAL_PG=1 Sep 30, 2025
Copy link

github-actions bot commented Sep 30, 2025

2025-09-30 20:16:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for a27f9a6 has started.
2025-09-30 20:17:04 UTC Artifacts will be uploaded here
2025-09-30 20:20:14 UTC ya make is running...
🟡 2025-09-30 20:59:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6974 6831 0 2 130 11

2025-09-30 20:59:46 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-09-30 21:08:26 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
47 (only retried tests) 37 0 0 0 10

🟢 2025-09-30 21:08:29 UTC Build successful.
🟢 2025-09-30 21:08:42 UTC ydbd size 2.2 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 57f0b05 merge: a27f9a6 diff diff %
ydbd size 2 397 779 880 Bytes 2 397 779 880 Bytes 0 Bytes 0.000%
ydbd stripped size 512 649 384 Bytes 512 649 384 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 30, 2025

2025-09-30 20:20:28 UTC Pre-commit check linux-x86_64-release-asan for a27f9a6 has started.
2025-09-30 20:20:43 UTC Artifacts will be uploaded here
2025-09-30 20:23:32 UTC ya make is running...
🟡 2025-09-30 21:34:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3108 2859 0 61 180 8

🟢 2025-09-30 21:34:43 UTC Build successful.
🟢 2025-09-30 21:35:03 UTC ydbd size 3.7 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 57f0b05 merge: a27f9a6 diff diff %
ydbd size 3 988 033 712 Bytes 3 988 033 616 Bytes -96 Bytes -0.000%
ydbd stripped size 1 486 466 560 Bytes 1 486 466 496 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@asmyasnikov asmyasnikov merged commit 65c2dde into main Sep 30, 2025
28 of 36 checks passed
@asmyasnikov asmyasnikov deleted the index_auto_choose_mode branch September 30, 2025 23:35
nfrmtk pushed a commit to nfrmtk/ydb that referenced this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/queryprocessor Query processor issues and requests bugfix local-ydb
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants