Specify version in meson.build #2139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I saw one file that has this version as macro, maybe you could use git hooks or ci to make them always match |
|
On Fri May 16, 2025 at 3:55 AM CEST, yhirose wrote:
@Tachi107 do you have any comment on this issue?
Maybe "version: version" could be added to the declare_dependency call
|
|
Oh i see now, i didn't look deep into meson.build |
I prefer to specify version when I'm calling dependency() and lack of makes me unable to do it
|
@Tachi107 could you please review the new change? If you approve it, I'll merge it. Thanks! |
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I prefer to specify version when I'm calling dependency() and lack of makes me unable to do it