Skip to content

Fix @return annotation for CompositeUrlRule::createRules() #20585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix @return annotation for CompositeUrlRule::createRules() #20585

wants to merge 2 commits into from
+2 −1

Conversation

mspirkov
Copy link
Contributor

@mspirkov mspirkov commented Oct 8, 2025

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Fixed issues

mspirkov
mspirkov commented Oct 8, 2025
View reviewed changes
framework/web/CompositeUrlRule.php
/**
* Creates the URL rules that should be contained within this composite rule.
* @return UrlRuleInterface[] the URL rules
* @return UrlRuleInterface[]|UrlRuleInterface[][] the URL rules
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@mspirkov mspirkov marked this pull request as ready for review October 8, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terabytesoftw terabytesoftw terabytesoftw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mspirkov @terabytesoftw