Require version when loading gem #897
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apps and other gems (like lookbook) want to be able to easily tell whether they are working with Phlex v1 or v2, and lookbook is now trying to check `Phlex::VERSION` for that, which is not loaded by default. Signed-off-by: Mark Oleson <fusion2004@gmail.com>
|
Which version are you using? It seems that after 2.1 the version is always loaded, If you are < 2.1, you need to |
|
Ah, you're correct, I'm on 2.0 until our app finishes upgrade from rails 7.1 to 7.2. Okay, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apps and other gems (like lookbook) want to be able to easily tell whether they are working with Phlex v1 or v2, and lookbook is now trying to check
Phlex::VERSIONfor that, which is not loaded by default.Would it make sense to always load that? It seems like other major gems I checked, like sidekiq, do.