Comma-separated tokens #904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeldrapper
commented
May 7, 2025
lib/phlex/sgml/elements.rb
Outdated
Comment on lines
5
to
9
| img: <<~RUBY, | ||
| if (tokens = attributes[:srcset]) | ||
| attributes[:srcset] = __nested_tokens__(tokens, ", ") | ||
| end | ||
| RUBY |
There was a problem hiding this comment.
The technique here is to generate specifically optimised code to check and pre-process the comma-separated-lists before caching takes place. We could cache this step separately but I don’t think it’s worth it.
joeldrapper
commented
May 7, 2025
| @@ -23,6 +56,7 @@ def #{method_name}(**attributes) | |||
| if block_given # with content block | |||
| buffer << "<#{tag}" | |||
| begin | |||
| #{COMMA_SEPARATED_TOKENS[method_name]} | |||
There was a problem hiding this comment.
This outputs nothing for most elements and otherwise outputs the code to pre-process one or two values if they exist before caching.
willcosgrove
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #882