Adding missing SMOS40 registers #249
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added missing registers
added missing registers
|
A lot of lines are removed with this PR from the CSV as wel as the json. I've made an export myself and I see a different number of lines in my export compared to the export from Nikoheld. It looks like registers appear or disappear when enabling or disabling functions in de SMOS40. In the current source CSV is see signs of an RMU S40, which are removed by Nikoheld. How should this be handled? The README states no changes should be made to the csv, but I think new lines should be merged into the current CSV, and maybe update lines where applicable. |
|
@storeman I usually merge manually. Add new lines, replace existing with similar register type and number. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Please select the type of your PR:
Description
Heatpump model: SMOS40
Firmware version: 4.4.7
Checklist