chore(ci): use trusted publishing for npm packages #2913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceTDrinker
reviewed
Oct 16, 2025
| - name: Authenticate on NPM | ||
| uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0 | ||
| with: | ||
| node-version: '24' |
There was a problem hiding this comment.
it does not match our node version I believe (22) is that a problem ?
There was a problem hiding this comment.
Let's use the same Node version indeed.
There was a problem hiding this comment.
up to you :
proposal: make it dynamic by fetching the info in the makefile
can be done now or in a later PR, as you wish
|
you can rebase, CI fixes have been merged |
soonum
force-pushed
the
dt/ci/npm_trusted_publishing
branch
from
9807c88 to
8984776
Compare
IceTDrinker
approved these changes
Oct 17, 2025
IceTDrinker
reviewed
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.