Skip to content

Conversation

agnesLeroy
Copy link
Contributor

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@IceTDrinker
Copy link
Member

@agnesLeroy could you verify if it was yielding similar results ?

@agnesLeroy
Copy link
Contributor Author

Yes, but SXM5's are out of stock again I'll try tomorrow

@IceTDrinker
Copy link
Member

Sorry I meant "did you have a chance to verify it"

@agnesLeroy agnesLeroy force-pushed the al/quick_option_criterion branch from 7a3fc44 to fabbcb1 Compare October 17, 2025 08:16
@IceTDrinker
Copy link
Member

I'm good to accept if the numbers match what you expect @agnesLeroy :)

@agnesLeroy
Copy link
Contributor Author

agnesLeroy commented Oct 17, 2025

No I get a crash with the quick option: https://github.com/zama-ai/tfhe-rs/actions/runs/18586797523/job/52993143637. I have another commit in this PR to use profile release_lto_off for gpu benches and with this commit I could measure the same results for the erc20 bench on SXM5. But the quick option makes the bench crash.

@agnesLeroy agnesLeroy closed this Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants