Handle approval rules #874
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WebUI provides a mechanism to view the status of MR approval rules on a specific MR. Add this functionality to lab. Usage: 'lab mr approval-rule 1234' One thing to note is that, unlike the WebUI, lab currently does not show the 'Commented By' data. This is because getting the data is expensive, and at this time provides little functionality. This can be added if users request it. Signed-off-by: Prarit Bhargava <prarit@redhat.com>
prarit
force-pushed
the
handle_approval_rules
branch
14 times, most recently
from
09f3afb to
4e5957d
Compare
Functionality exists to create and delete merge request approval rules, along with the viewing of merge request approval rules. Add the ability to create and delete merge request approval rules. Signed-off-by: Prarit Bhargava <prarit@redhat.com>
prarit
force-pushed
the
handle_approval_rules
branch
from
4e5957d to
04dfcfe
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #874 +/- ##
==========================================
- Coverage 55.56% 54.74% -0.82%
==========================================
Files 82 83 +1
Lines 5977 6081 +104
==========================================
+ Hits 3321 3329 +8
- Misses 2367 2464 +97
+ Partials 289 288 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to add, delete, and list merge request approval rules.
Closes #835
Signed-off-by: Prarit Bhargava prarit@redhat.com