Skip to content

Test endianess support against zarr-python data types refactor #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

TomNicholas
Copy link
Member

This PR is for testing support for @d-v-b's unmerged zarr data types refactor in zarr-developers/zarr-python#2874. Particularly we care about supporting big-endian data.

  • Closes #xxxx
  • Tests added
  • Tests passing
  • Full type hint coverage
  • Changes are documented in docs/releases.rst
  • New functions/methods are listed in api.rst
  • New functionality has documentation

@TomNicholas TomNicholas added zarr-python Relevant to zarr-python upstream zarr-specs Requires adoption of a new ZEP testing v3-migration Required for migration to Zarr-Python 3.0 test-upstream Run the upstream tests on this PR labels Apr 11, 2025
Co-authored-by: Ian Hunt-Isaak <ianhuntisaak@gmail.com>
Co-authored-by: Ian Hunt-Isaak <ianhuntisaak@gmail.com>
@TomNicholas
Copy link
Member Author

This is still using the wrong installed version 😞

We would appreciate you help with this @maxrjones

@maxrjones maxrjones added test-upstream Run the upstream tests on this PR and removed test-upstream Run the upstream tests on this PR labels Apr 11, 2025
@ianhi
Copy link

ianhi commented Apr 11, 2025

hooray!
image

@maxrjones
Copy link
Member

yeah the proper version is installed for the upstream tests (removing and adding test-upstream should trigger those) but looks like there'll be lots of failures and the tests are running slower - https://github.com/zarr-developers/VirtualiZarr/actions/runs/14409577052/job/40414132555?pr=545.

@maxrjones
Copy link
Member

might be worth trying the upstream tests out locally because it looks like the CI's hanging

@@ -91,7 +91,7 @@ upstream = [
'universal_pathlib @ git+https://github.com/fsspec/universal_pathlib',
'numcodecs @ git+https://github.com/zarr-developers/numcodecs',
'ujson @ git+https://github.com/ultrajson/ultrajson',
'zarr @ git+https://github.com/zarr-developers/zarr-python',
'zarr @ git+https://github.com/ianhi/zarr-python@feat/fixed-length-strings',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'zarr @ git+https://github.com/ianhi/zarr-python@feat/fixed-length-strings',
'zarr @ git+https://github.com/d-v-b/zarr-python@feat/fixed-length-strings',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-upstream Run the upstream tests on this PR testing v3-migration Required for migration to Zarr-Python 3.0 zarr-python Relevant to zarr-python upstream zarr-specs Requires adoption of a new ZEP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants