config/microblaze: fix whitespace in LINK_SPEC is breaking linking #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitespace is causing the intended output of `-dT xilinx.ld%s` to be split and takeninto if-exists-then-else as 2nd and 3rd arguments so LINK_SPEC emits `-dT` when xilinx.ld is found, and emits xilinx.ld when not found. Signed-off-by: Alp Sayin <alpsayin@gmail.com>
keith-packard
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whitespace is causing the intended output of
-dT xilinx.ld%sto be split and takeninto if-exists-then-else as 2nd and 3rd arguments so LINK_SPEC emits-dTwhen xilinx.ld is found, and emits xilinx.ld when not found.Testing:
I've sneakily pushed this patch into #58 to get a toolchain out and tested it with picolibc.