pico-sdk: adapt for the sha256 driver to Zephyr #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajf58 @ThreeEights @petejohanson @kartben Could you take a look if you have a time, please? |
dsseng
reviewed
Jul 31, 2025
ChangeLog.zephyr.md
Outdated
| @@ -3,6 +3,9 @@ | |||
| Need to take care to not break these changes when updating pico-sdk. | |||
|
|
|||
| ## Patch List: | |||
| - [#10] pico-sdk: Disabling sanity check the IRQ status | |||
There was a problem hiding this comment.
Suggested change
| - [#10] pico-sdk: Disabling sanity check the IRQ status | |
| - [#10] pico-sdk: Disabling DMA routines and sanity check the IRQ status |
Crypto subsystem does support DMA though, so if this feature becomes desired, then should it be implemented in the Zephyr driver part? Couldn't the existing HAL code be used for DMA operations?
There was a problem hiding this comment.
DMA operations must be performed via the Zephyr DMA driver, so the HAL code cannot be used. DMA support must be implemented separately.
There was a problem hiding this comment.
Reasonable, most of that code just calls into HAL DMA methods
Comment out unused DMA-related code and add wrappers to expose internal functions. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Add a note about the sha256 zephyr adaptation. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment out unused DMA-related code and add wrappers to expose
internal functions.