drivers: ethernet: phy: add driver for ksz9131, update ksz8081 with interrupt support #90711

TonyHan11 · 2025-05-28T04:31:42Z

This PR includes:

add the driver for Microchip KSZ9131 Ethernet PHY
add interrupt mode support for KSZ8081

pdgendt · 2025-05-28T07:00:55Z

Add an entry to https://github.com/zephyrproject-rtos/zephyr/blob/main/tests/drivers/build_all/ethernet/app.overlay so it builds in CI.

dts/bindings/ethernet/microchip,ksz9131.yaml

drivers/ethernet/phy/phy_microchip_ksz9131.c

TonyHan11 · 2025-05-28T08:15:27Z

@pdgendt An entry for ksz9131 added to tests/drivers/build_all/ethernet/app.overlay, thanks.

maass-hamburg · 2025-05-28T08:18:27Z

@TonyHan11 pls add PR description and address the things from sonarqube

TonyHan11 · 2025-05-28T08:19:09Z

@maass-hamburg updated with removing the unused property, renaming LINK_*BASED_T and fixing if (ret), thank you very much.

drivers/ethernet/phy/phy_microchip_ksz8081.c

drivers/ethernet/phy/phy_microchip_ksz9131.c

TonyHan11 · 2025-06-03T05:40:21Z

@maass-hamburg
Thank you for your comments. Commits updated with the following changes:

using goto instead of do while (0)
update if (ret) to if (ret < 0)
fix the issues reported by SonarQube Cloud
remove comments TODO change this to GPIO interrupt driven

drivers/ethernet/phy/Kconfig

TonyHan11 · 2025-06-09T05:29:49Z

Resolve the CI error by rebasing the commits (without changes).

drivers/ethernet/phy/phy_microchip_ksz8081.c

kartben · 2025-06-26T08:28:53Z

drivers/ethernet/phy/phy_microchip_ksz9131.c

+	reg_val |= PHY_KSZ9131_ICS_LINK_UP_IE_MASK | PHY_KSZ9131_ICS_LINK_DOWN_IE_MASK;
+
+	/* Write settings to Interrupt Control/Status register */
+	ret = ksz9131_write(dev, 27, reg_val);


Use PHY_KSZ9131_ICS_REG macro instead of magic number

drivers/ethernet/phy/phy_microchip_ksz9131.c

kartben · 2025-06-26T08:41:53Z

drivers/ethernet/phy/phy_microchip_ksz8081.c

+		goto done;
+	}
+
+	gpio_init_callback(&data->gpio_callback, phy_mc_ksz8081_interrupt_handler,


Suggested change

gpio_init_callback(&data->gpio_callback, phy_mc_ksz8081_interrupt_handler,

ret = gpio_init_callback(&data->gpio_callback, phy_mc_ksz8081_interrupt_handler,

TonyHan11 · 2025-07-18T01:17:03Z

Rebased to the latest main branch.

maass-hamburg · 2025-07-18T07:49:20Z

drivers/ethernet/phy/phy_microchip_ksz9131.c

+	struct k_work_delayable monitor_work;
+	struct phy_link_state state;
+	struct k_sem sem;
+	bool gigabit_supported;


gigabit_supported bool is not needed, as this phy definetly supports gigabit and it be always be true, it is only in the generic phy driver, because there we don't know it because we don't know durring build if gigabit is supported.

Updated with removing gigabit_supported and code related. Thanks.

maass-hamburg · 2025-07-29T12:56:27Z

@TonyHan11 please rebase to current main

TonyHan11 · 2025-08-04T01:14:04Z

@TonyHan11 please rebase to current main

rebased, thanks.

maass-hamburg · 2025-08-04T07:18:13Z

drivers/ethernet/phy/phy_microchip_ksz9131.c

+		LOG_ERR("PHY (%d) init failed", cfg->phy_addr);
+	}
+
+	return ret;


apply changes from #91572 also to this phy

Updated with adding default-speeds for ksz9131, thanks.

maass-hamburg · 2025-08-26T08:12:10Z

drivers/ethernet/phy/Kconfig

+	depends on MDIO
+	depends on GPIO || (!$(dt_compat_any_has_prop,$(DT_COMPAT_MICROCHIP_KSZ9131),reset-gpios) && \
+			    !$(dt_compat_any_has_prop,$(DT_COMPAT_MICROCHIP_KSZ9131),int-gpios))


apply changes from #94806

Rebased and updated with the changes applied.

maass-hamburg · 2025-08-26T08:15:47Z

drivers/ethernet/phy/phy_microchip_ksz9131.c

+	uint16_t anar = 0;
+	int ret = 0;
+
+	(void)config; /* avoid warnings due to config is only used in LOG_DBG() */


use __maybe_unused attribute on config instead

Fixed, thanks.

maass-hamburg · 2025-08-26T08:29:29Z

drivers/ethernet/phy/phy_microchip_ksz9131.c

+		goto done;
+	}
+
+	ret = phy_mchp_ksz9131_autonegotiate(dev);


consider adding the changes from #93118 here too and using phy_mii_cfg_link_autoneg

Improve some of the logging.
No changes with auto-negotiate due to no block issue in ksz9131 using interrupt mode.
It seems that the interrupt mode for ksz8081 is not fully supported in the PR.

sonarqubecloud · 2025-08-28T07:54:42Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Add support for KSZ9131 (Gigabit Ethernet Transceiver with RGMII Support). As first starter, 100MBit/s mode is tested. https://www.microchip.com/en-us/product/ksz9131 Signed-off-by: Tony Han <tony.han@microchip.com>

Add build tests for Microchip KSZ9131. Signed-off-by: Tony Han <tony.han@microchip.com>

Enable Link-Up and Link-Down interrupts. On the interrupt handling the monitor work is scheduled to update the link status and calling corresponding callback routine. Signed-off-by: Tony Han <tony.han@microchip.com>

Read gigabit status from Master Slave Status Register. Signed-off-by: Tony Han <tony.han@microchip.com>

github-actions bot added the area: Ethernet label May 28, 2025

github-actions bot requested review from clamattia, decsny, lmajewski, maass-hamburg and pdgendt May 28, 2025 04:32

github-actions bot assigned maass-hamburg May 28, 2025

maass-hamburg requested changes May 28, 2025

View reviewed changes

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch from 6944d51 to 5055226 Compare May 28, 2025 08:09

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch from 5055226 to cfd8c64 Compare May 29, 2025 01:21

maass-hamburg requested changes Jun 2, 2025

View reviewed changes

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch 4 times, most recently from 1ac4658 to e7778f7 Compare June 3, 2025 04:41

maass-hamburg reviewed Jun 3, 2025

View reviewed changes

drivers/ethernet/phy/Kconfig Outdated Show resolved Hide resolved

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch 2 times, most recently from ffe8e46 to 94224d7 Compare June 9, 2025 04:51

TonyHan11 requested a review from maass-hamburg June 9, 2025 05:30

maass-hamburg requested changes Jun 10, 2025

View reviewed changes

drivers/ethernet/phy/phy_microchip_ksz8081.c Outdated Show resolved Hide resolved

drivers/ethernet/phy/phy_microchip_ksz8081.c Outdated Show resolved Hide resolved

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch from 94224d7 to 35d32e6 Compare June 10, 2025 09:27

maass-hamburg previously approved these changes Jun 10, 2025

View reviewed changes

kartben reviewed Jun 26, 2025

View reviewed changes

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch 2 times, most recently from 8892b25 to 6f9aced Compare June 30, 2025 04:53

TonyHan11 requested a review from maass-hamburg June 30, 2025 05:33

kartben added this to the v4.3.0 milestone Jul 1, 2025

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch 2 times, most recently from 27c6e59 to 5a9a2c6 Compare July 2, 2025 03:33

TonyHan11 requested a review from kartben July 15, 2025 08:17

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch from 5a9a2c6 to 50f538d Compare July 17, 2025 06:12

maass-hamburg requested changes Jul 18, 2025

View reviewed changes

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch from 50f538d to 3e074d0 Compare July 18, 2025 08:08

TonyHan11 requested a review from maass-hamburg July 23, 2025 01:58

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch from 3e074d0 to a762fa7 Compare August 4, 2025 01:13

maass-hamburg reviewed Aug 4, 2025

View reviewed changes

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch 2 times, most recently from ef7bf97 to a2640e1 Compare August 4, 2025 09:40

TonyHan11 requested a review from maass-hamburg August 26, 2025 01:31

maass-hamburg requested changes Aug 26, 2025

View reviewed changes

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch from a2640e1 to 93fc888 Compare August 28, 2025 07:20

zephyrbot requested a review from ClaCodes August 28, 2025 07:21

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch from 93fc888 to cc48784 Compare August 28, 2025 07:51

TonyHan11 added 5 commits August 28, 2025 16:06

drivers: ethernet: phy: add Microchip's KSZ9131 PHY support

cc763c8

Add support for KSZ9131 (Gigabit Ethernet Transceiver with RGMII Support). As first starter, 100MBit/s mode is tested. https://www.microchip.com/en-us/product/ksz9131 Signed-off-by: Tony Han <tony.han@microchip.com>

tests: drivers: build_all: ethernet: Add KSZ9131 entry

593b59e

Add build tests for Microchip KSZ9131. Signed-off-by: Tony Han <tony.han@microchip.com>

drivers: ethernet: phy: ksz8081: add support for phy interrupt mode

ca03628

Enable Link-Up and Link-Down interrupts. On the interrupt handling the monitor work is scheduled to update the link status and calling corresponding callback routine. Signed-off-by: Tony Han <tony.han@microchip.com>

drivers: ethernet: phy: ksz9131: add support for phy interrupt mode

2893310

Enable Link-Up and Link-Down interrupts. On the interrupt handling the monitor work is scheduled to update the link status and calling corresponding callback routine. Signed-off-by: Tony Han <tony.han@microchip.com>

drivers: ethernet: phy: ksz9131: add getting status for gigabit mode

cc48784

Read gigabit status from Master Slave Status Register. Signed-off-by: Tony Han <tony.han@microchip.com>

TonyHan11 requested a review from maass-hamburg August 28, 2025 08:29

	gpio_init_callback(&data->gpio_callback, phy_mc_ksz8081_interrupt_handler,
	ret = gpio_init_callback(&data->gpio_callback, phy_mc_ksz8081_interrupt_handler,

drivers: ethernet: phy: add driver for ksz9131, update ksz8081 with interrupt support #90711

Are you sure you want to change the base?

drivers: ethernet: phy: add driver for ksz9131, update ksz8081 with interrupt support #90711

Conversation

TonyHan11 commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pdgendt commented May 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TonyHan11 commented May 28, 2025

Uh oh!

maass-hamburg commented May 28, 2025

Uh oh!

TonyHan11 commented May 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TonyHan11 commented Jun 3, 2025

Uh oh!

Uh oh!

TonyHan11 commented Jun 9, 2025

Uh oh!

Uh oh!

Uh oh!

kartben Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TonyHan11 commented Jul 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maass-hamburg commented Jul 29, 2025

Uh oh!

TonyHan11 commented Aug 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Aug 28, 2025

Quality Gate passed

Uh oh!

Uh oh!

TonyHan11 commented May 28, 2025 •

edited

Loading

kartben Jun 26, 2025 •

edited

Loading