scripts: ci: Check compliance checkpatch module fixes #92327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Continuous Integration
area: Coding Guidelines
github-actions
bot
requested review from
carlescufi,
fabiobaltieri,
jfischer-no,
kartben,
keith-zephyr,
nashif,
simhein and
stephanosio
kartben
reviewed
Jun 27, 2025
scripts/ci/check_compliance.py
Outdated
| @@ -323,6 +323,8 @@ def run(self): | |||
| if len(matches) == 0: | |||
| self.failure(output) | |||
|
|
|||
| diff.communicate() | |||
There was a problem hiding this comment.
I will let @pdgendt comment and confirm but I think the "Python way" would be to use a context manager
with subprocess.Popen(.. blah... ) as diff:
try:
...
kartben
reviewed
Jul 1, 2025
| @@ -4,7 +4,7 @@ | |||
| # zephyr-keep-sorted-start | |||
| clang-format>=15.0.0 | |||
| gitlint | |||
| junitparser>=2 | |||
| junitparser>=4.0.1 | |||
There was a problem hiding this comment.
You should also update requirements-action.in and regenerate requirements-action.txt as right now it has 3.2.0 pinned (which I guess doesn't have the bug, which makes the update not strictly mandatory, perhaps)
The git diff subprocess was leaking, ie., it was still running with it's file streams open, and python was printing warnings about this. Fix by calling communicate() on the object which will do the cleanup. Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
junitparser had a bug causing a traceback when running the checkpatch check compliance module, fix is in 4.0.1 of junitparser from this PR: weiwei/junitparser#168 Update requirements to make sure we get this version. Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
decsny
force-pushed
the
check_compliance_fixes_6_27
branch
from
7d5edb5 to
f64476c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
the code scan check is failing due to something I am not actually adding on this PR, that I don't understand... |
pdgendt
approved these changes
Jul 15, 2025
fabiobaltieri
approved these changes
Jul 15, 2025
kartben
approved these changes
Jul 15, 2025
stephanosio
approved these changes
Jul 15, 2025
decsny
changed the title
keith-zephyr
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92324