Skip to content

doc: contribute: fix dead link in RFC proposal template #92344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025

Conversation

moonlight83340
Copy link
Contributor

Fix a broken link in the 'contribute/proposals_and_rfcs.rst' file that pointed to a non-existent Markdown RFC template.

The link previously pointed to:
.github/ISSUE_TEMPLATE/003_rfc-proposal.md

It has been corrected to point to the actual YAML file:
.github/ISSUE_TEMPLATE/003_rfc-proposal.yml

Fix #92342

@moonlight83340 moonlight83340 marked this pull request as ready for review June 28, 2025 11:32
@github-actions github-actions bot added size: XS A PR changing only a single line of code area: Documentation labels Jun 28, 2025
@nashif nashif added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Jul 1, 2025
@nashif nashif modified the milestones: v4.3.0, v4.2.0 Jul 1, 2025
Copy link
Member

@nashif nashif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, it does not make sense to be linking to the template or what used to be a template, instead change the text to point to the form available at

https://github.com/zephyrproject-rtos/zephyr/issues/new?template=003_rfc-proposal.yml

kartben
kartben previously approved these changes Jul 3, 2025
Fix a broken link in the 'contribute/proposals_and_rfcs.rst' file that
pointed to a non-existent Markdown RFC template.

The link previously pointed to:
  .github/ISSUE_TEMPLATE/003_rfc-proposal.md

It has been corrected to point to the actual YAML file:
  .github/ISSUE_TEMPLATE/003_rfc-proposal.yml

Fixes: zephyrproject-rtos#92342

Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
@kartben kartben dismissed stale reviews from henrikbrixandersen and themself via ed71064 July 3, 2025 20:07
@kartben
Copy link
Contributor

kartben commented Jul 3, 2025

@moonlight83340 I just realized @nashif was also suggesting that the paragraph where the link is used needed to be updated so I took the liberty to do just that.

Copy link

sonarqubecloud bot commented Jul 3, 2025

@danieldegrasse danieldegrasse merged commit 1b6a0e4 into zephyrproject-rtos:main Jul 4, 2025
20 checks passed
@moonlight83340 moonlight83340 deleted the issue_92342 branch July 9, 2025 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Documentation size: XS A PR changing only a single line of code Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: Dead link issue in 'contribute/proposals_and_rfcs'
7 participants