mcumgr: relocate uart transport #92359
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The uart_mcumgr.c implements the APIs used by the smp_uart.c but lives in the drivers/console folder which is kinda awkward, as the files in the drivers/console generally implements the stdout & printk hooks. Relocate it into subsys/mgmt/mcumgr/transport/src/ alongside smp_uart.c instead. Signed-off-by: Yong Cong Sin <yongcong.sin@gmail.com>
ycsin
force-pushed
the
pr/reloc-uart_mcumgr
branch
from
7751f1c to
31ce009
Compare
|
ycsin
commented
Jul 1, 2025
| @@ -10,16 +10,16 @@ | |||
| */ | |||
|
|
|||
| /* Define required for uart_mcumgr.h functionality reuse */ | |||
| #define CONFIG_UART_MCUMGR_RX_BUF_SIZE CONFIG_MCUMGR_TRANSPORT_DUMMY_RX_BUF_SIZE | |||
| #define CONFIG_MCUMGR_TRANSPORT_UART_RX_BUF_SIZE CONFIG_MCUMGR_TRANSPORT_DUMMY_RX_BUF_SIZE | |||
There was a problem hiding this comment.
RFC: I'm also inclined to remove the uart/serial dependencies so that smp_dummy is completely standalone, at the expense of some code duplication, any idea?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The uart_mcumgr.c implements the APIs used by the smp_uart.c but lives in the drivers/console folder which is kinda awkward, as the files in the drivers/console generally implements the stdout & printk hooks.
Relocate it into subsys/mgmt/mcumgr/transport/src/ alongside smp_uart.c instead.
TODO: