Skip to content

Update esptool v5 as a package #92894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

marekmatej
Copy link

@marekmatej marekmatej commented Jul 9, 2025

This PR brings the changes in how the esptool is installed in the system. Instead of hard-copy in the hal/espressif, it put the esptool on the list of required packages. This reflects the new esptool v5.0.0, which comes with several breaking changes.

Copy link

github-actions bot commented Jul 9, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_espressif zephyrproject-rtos/hal_espressif@f3453bd (hal_idf-5.1_zep-4.2,zephyr) zephyrproject-rtos/hal_espressif@82bc519 (main) zephyrproject-rtos/hal_espressif@f3453bde..82bc519b

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_espressif DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jul 9, 2025
@marekmatej marekmatej requested a review from kartben July 9, 2025 12:02
Copy link
Contributor

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you said you were going to add this dependency in the hal_espressif module?

Something like https://github.com/zephyrproject-rtos/nanopb/blob/master/zephyr/module.yml#L5-L8

@marekmatej
Copy link
Author

marekmatej commented Jul 9, 2025

The current esptool-5.0.0 has a bug that affects some Zephyr builds; therefore, we need to wait for the fix, which will be released as 5.0.1.
EDIT: we move forward to 5.0.2 because it fixes the load issues related to flashing multiple binaries. For example, when using sysbuild.

@marekmatej marekmatej force-pushed the feature/esptool_v5_package branch 3 times, most recently from f86d481 to 89cd47f Compare July 15, 2025 19:34
@marekmatej marekmatej force-pushed the feature/esptool_v5_package branch from 89cd47f to 3ad522b Compare July 23, 2025 16:43
@github-actions github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Jul 23, 2025
@marekmatej marekmatej marked this pull request as ready for review July 23, 2025 17:29
@marekmatej marekmatej requested a review from kartben July 23, 2025 17:29
@marekmatej marekmatej force-pushed the feature/esptool_v5_package branch from 4e3ece3 to 3d91227 Compare July 28, 2025 21:51
@marc-hb marc-hb removed their request for review July 28, 2025 21:54
wmrsouza
wmrsouza previously approved these changes Jul 29, 2025
raffarost
raffarost previously approved these changes Jul 29, 2025
@marekmatej marekmatej dismissed stale reviews from raffarost and wmrsouza via cbc787e July 30, 2025 14:40
@marekmatej marekmatej force-pushed the feature/esptool_v5_package branch from 3d91227 to cbc787e Compare July 30, 2025 14:40
@zephyrbot zephyrbot requested a review from uLipe July 30, 2025 14:42
@marekmatej marekmatej force-pushed the feature/esptool_v5_package branch from cbc787e to 3db76b7 Compare July 30, 2025 14:45
raffarost
raffarost previously approved these changes Jul 30, 2025
sylvioalves
sylvioalves previously approved these changes Jul 31, 2025
wmrsouza
wmrsouza previously approved these changes Jul 31, 2025
* Brings changes in how esptool is istalled in the environment.
* Update bluetooth and C2 support files.

Signed-off-by: Marek Matej <marek.matej@espressif.com>
@marekmatej marekmatej dismissed stale reviews from wmrsouza, sylvioalves, and raffarost via 5bd87dc August 4, 2025 13:55
@marekmatej marekmatej force-pushed the feature/esptool_v5_package branch from 3db76b7 to 5bd87dc Compare August 4, 2025 13:55
Updated twister.yaml workflow to fetch esptool for the CI.
Fix format of the arguments used in the esptool-5.0.2.
Check that esptool is available on build time.
Update runners for esp32.

Signed-off-by: Marek Matej <marek.matej@espressif.com>
@marekmatej marekmatej force-pushed the feature/esptool_v5_package branch from 5bd87dc to 9c533c6 Compare August 4, 2025 15:45
Copy link

sonarqubecloud bot commented Aug 4, 2025

@cfriedt cfriedt merged commit fa18402 into zephyrproject-rtos:main Aug 4, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants