mgmt: ec_host_cmd: usb: fix 2 bugs #96834
Open
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using net_buf_reset for net buffers with external memory is not allowed. Do not use it for tx_buf. Reset the buffer by restoring the default buffer manually. Signed-off-by: Dawid Niedzwiecki <dawidn@google.com>
Fix double free of a net buffer after request error. Signed-off-by: Dawid Niedzwiecki <dawidn@google.com>
|
jfischer-no
reviewed
Oct 1, 2025
| k_work_schedule(&ctx->reset_work, K_MSEC(IN_TRANSFER_TIMEOUT_MS)); | ||
|
|
||
| net_buf_reset(ctx->usb_tx_buf); | ||
| ctx->usb_tx_buf->data = ctx->tx_buf->buf; |
There was a problem hiding this comment.
I do not see the issue, what is the problem with net_buf_reset?
There was a problem hiding this comment.
net_buf_reset doesn't accept buffers with external data flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes 2 bugs in the backend: