drivers: timer: nrf_grtc: Move GRTC initialization to early init #96837
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
anangl,
andyross,
bjarki-andreasen,
jaz1-nordic,
kl-cruz,
lstnl,
magp-nordic,
masz-nordic,
nika-nordic and
teburd
|
Can you add a comment in commit message with reasoning behind splitting init into two stages? |
GRTC is used by the logger, so it must be initialized as early as possible. On the other hand, clock requests are allowed once the clock control API has been initialized. This PR introduces a two-stage GRTC initialization to meet these requirements. Signed-off-by: Adam Kondraciuk <adam.kondraciuk@nordicsemi.no>
adamkondraciuk
force-pushed
the
NRFX-8454-Move_GRTC-initialization
branch
from
08656d6 to
fa3cb0a
Compare
|
|
Are you certain the logger is available pre kernel? semaphores and the kernel/system timer are not available before POST_KERNEL, so I would expect logging to not be ready either |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GRTC is used by the logger, so it must be initialized
as early as possible. On the other hand, clock requests
are allowed once the clock control API has been initialized.
This PR introduces a two-stage GRTC initialization to meet
these requirements.