Shell history use k_heap instead of ring_buffer #96862
Open
+56
−196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Tests
Mattemagikern
force-pushed
the
shell_history
branch
2 times, most recently
from
66f46ef to
fd2394f
Compare
The ring_buffer API was not ideal for this use case, as it is designed for concurrent access, which is not needed here. The new implementation using k_heap is more readable and easier to maintain. There is a slight penalty in memory usage & effectiveness due to the overhead of k_heap, but since this isn't a production-critical path, the trade-off is acceptable. Signed-off-by: Måns Ansgariusson <Mansgariusson@gmail.com>
The shell history initialization function doesn't work in if the shell instance hasn't been created through the shell macro. This removes the function to avoid confusion. Signed-off-by: Måns Ansgariusson <Mansgariusson@gmail.com>
Mattemagikern
force-pushed
the
shell_history
branch
from
fd2394f to
eb93215
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-requisite for: #96861