std.Io.Writer: fix splatBytesAll #24567
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrk
requested changes
Jul 26, 2025
There was a problem hiding this comment.
As much as I love silly things, if you want to add SillyStream can you make it not silly and add it to std.testing?
otherwise, feel free to close this since a fix landed in 66e49d9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure the regression test (i.e. change to existing test) is worth including/appropriate since it's a bit complicated and is probably not clear what it's doing - it can presumably be simplified, this is just the first small example I came up with. The point is that to trigger the bug, a stream needs to only partially do a the
splatBytescall and then have the calls towriteSplatnot coincidentally write the correct amount, but overflow the counter.