Rails 6: Graphql class based approach #1623
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| if next? | ||
| gem "rails", '~> 6.0' | ||
| else | ||
| gem 'rails', '~> 5.2' |
There was a problem hiding this comment.
Bundler/DuplicatedGem: Gem rails requirements already given on line 15 of the Gemfile.
| # Bundle edge Rails instead: gem 'rails', github: 'rails/rails' | ||
| gem 'rails', '~> 5.2' | ||
| if next? | ||
| gem "rails", '~> 6.0' |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| @@ -1,3 +1,6 @@ | |||
| def next? | |||
| File.basename(__FILE__) == "Gemfile.next" | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| @@ -1,3 +1,6 @@ | |||
| def next? | |||
There was a problem hiding this comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
| class CaesarSchema < GraphQL::Schema | ||
| query(Types::QueryRoot) | ||
| mutation(Types::MutationRoot) | ||
| end |
There was a problem hiding this comment.
Layout/TrailingBlankLines: Final newline missing.
| @@ -0,0 +1,9 @@ | |||
| # app/graphql/types/credential_type.rb | |||
There was a problem hiding this comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
| field 'url', String, null: true | ||
| field 'status', Enums::DataRequestStatus, null: false | ||
| end | ||
| end |
There was a problem hiding this comment.
Layout/EndAlignment: end at 12, 2 is not aligned with module at 2, 0.
| @@ -0,0 +1,12 @@ | |||
| # app/graphql/types/data_request.rb | |||
| module Types | |||
| class DataRequest < GraphQL::Schema::Object | |||
There was a problem hiding this comment.
Layout/IndentationWidth: Use 2 (not 4) spaces for indentation.
Style/Documentation: Missing top-level class documentation comment.
| @@ -0,0 +1,12 @@ | |||
| # app/graphql/types/data_request.rb | |||
There was a problem hiding this comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
| # app/graphql/types/enums/data_request_requested_data.rb | ||
| module Types | ||
| module Enums | ||
| class DataRequestRequestedData < GraphQL::Schema::Enum |
There was a problem hiding this comment.
Style/Documentation: Missing top-level class documentation comment.
Error is caused due to changes from use of objects to classes from graphql
1.xxto2.xxSee:
https://imaharu.github.io/graphql-ruby-doc-ja/schema/class_based_api.html
https://graphql-ruby.org/mutations/mutation_classes