Skip to content

Enable install & testing against Python 3.12 #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

neiljp
Copy link
Collaborator

@neiljp neiljp commented Apr 13, 2023

What does this PR do, and why?

This PR is intended to

  • check that dependencies work satisfactorily under Python 3.12
  • ensure that we install under Python 3.12

These also enabled confirmation that after the 0.2.0/0.2.1 release yanks, that installing under an unsupported python does not install a very old option any more 👍

NOTE: This does not guarantee that there are no issues with python 3.12. For that we likely need urwid 2.2+ (http://urwid.org/changelog.html#release-2-2-0), however that also removes python 3.7 compatibility.

Outstanding aspect(s)

  • Wait for Python 3.12 release
  • Ensure that dependencies install OK
  • Tests run OK against the release?
  • Manual testing?

External discussion & connections

  • Discussed in #zulip-terminal in topic
  • Fully fixes #
  • Partially fixes issue #
  • Builds upon previous unmerged work in PR #
  • Is a follow-up to work in PR #
  • Requires merge of PR #
  • Merge will enable work on #

How did you test this?

  • Manually - Behavioral changes
  • Manually - Visual changes
  • Adapting existing automated tests
  • Adding automated tests for new behavior (or missing tests)
  • Existing automated tests should already cover this (only a refactor of tested code)

Self-review checklist for each commit

  • It is a minimal coherent idea
  • It has a commit summary following the documented style (title & body)
  • It has a commit summary describing the motivation and reasoning for the change
  • It individually passes linting and tests
  • It contains test additions for any new behavior
  • It flows clearly from a previous branch commit, and/or prepares for the next commit

@neiljp neiljp added the area: infrastructure Project infrastructure label Apr 13, 2023
@zulipbot zulipbot added the size: XS [Automatic label added by zulipbot] label Apr 13, 2023
@neiljp neiljp force-pushed the 2023-04-13-CI-Python-3.12-test branch 2 times, most recently from b70c89c to 75b5633 Compare April 13, 2023 20:56
@neiljp neiljp changed the title [DNM] Ensure later python versions don't cause issues with installation [DNM] Test install against Python 3.12-dev Apr 13, 2023
@neiljp neiljp added the FUTURE label Apr 13, 2023
@neiljp neiljp added this to the Next Release milestone Apr 13, 2023
@neiljp neiljp force-pushed the 2023-04-13-CI-Python-3.12-test branch from 75b5633 to 5d0f8b8 Compare June 4, 2023 01:11
@neiljp neiljp force-pushed the 2023-04-13-CI-Python-3.12-test branch from 5d0f8b8 to cdcf94f Compare October 24, 2023 22:49
@zulipbot zulipbot added size: S [Automatic label added by zulipbot] and removed size: XS [Automatic label added by zulipbot] labels Oct 24, 2023
@neiljp neiljp force-pushed the 2023-04-13-CI-Python-3.12-test branch from 747a5f3 to ce2c41a Compare October 24, 2023 23:30
@zulipbot zulipbot added size: XS [Automatic label added by zulipbot] and removed size: S [Automatic label added by zulipbot] labels Oct 24, 2023
@neiljp neiljp force-pushed the 2023-04-13-CI-Python-3.12-test branch 2 times, most recently from 0b19389 to 17e43fc Compare October 24, 2023 23:40
@zulipbot zulipbot added size: S [Automatic label added by zulipbot] and removed size: XS [Automatic label added by zulipbot] labels Oct 24, 2023
@neiljp neiljp changed the title [DNM] Test install against Python 3.12-dev Enable install & testing against Python 3.12 Oct 24, 2023
@neiljp neiljp marked this pull request as ready for review November 3, 2023 03:29
@neiljp neiljp removed the FUTURE label Nov 3, 2023
neiljp added 2 commits May 11, 2024 09:12
@neiljp neiljp force-pushed the 2023-04-13-CI-Python-3.12-test branch from 17e43fc to 572874a Compare May 11, 2024 16:13
@punchagan punchagan mentioned this pull request Aug 5, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: infrastructure Project infrastructure size: S [Automatic label added by zulipbot]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants