hellovai/tb: TypeBuilder -> TypeRegistry #2483
Draft
+9,466
−9,462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hellovai
commented
Sep 19, 2025
hellovai
commented
- Migrate TypeScript TypeBuilder to use baml_type_builder::TypeBuilder
- Keep original method names while using new type builder
- it works
- everything compiles!
- python works!
- Updated imports to use new type builder modules - Changed constructor to require runtime parameter like Python version - Updated method signatures to match new type builder API: - get_enum -> add_enum (with js_name = 'enum') - get_class -> add_class (with js_name = 'class') - set_type -> set_type (with js_name = 'type') - Updated error handling to return napi::Result<T> - Removed Default implementation since constructor requires runtime - Fixed type wrapping for FieldType in get_type method - Verified compilation succeeds
- Reverted method names to original: - get_enum (instead of add_enum) - get_class (instead of add_class) - set_type (kept as is) - Removed js_name attributes since using original names - Maintains backward compatibility with existing TypeScript API - Still uses new baml_type_builder::TypeBuilder internally
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This was referenced Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.