-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Add ReportCard and ReportsList components #1351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Implemented ReportCard component for displaying report details. - Created ReportsList component to render a list of ReportCard components. - Added tests for ReportCard and ReportsList with snapshot verification. - Introduced ResearchCategoryCard and ResearchCategoryList components for categorizing reports. - Included tests and snapshots for ResearchCategoryCard and ResearchCategoryList.
|
@koechkevin I've opened a new pull request, #1352, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@koechkevin Can you include a screenshot that shows how the cards line up when reports' description have different lengths? e.g. one line, 3 lines, 6 lines, etc. |
…es and update snapshots
… with improved text truncation styles and snapshot updates
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…oved link handling and update snapshots
kilemensi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't reviewed the code but the cards look alright to me.
Description
This PR Adds Card component without any payload implementation
Fixes #1345
Type of change
Please delete options that are not relevant.
Screenshots
Checklist: