Remove npm run test script to unblock publishing

[annajowang]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @annajowang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to unblock the publishing process for the @apphosting/build package by removing a specific npm run test script. This change directly addresses an identified impediment to package releases, ensuring a smoother and more efficient deployment workflow.

Highlights

• Script Removal: The 'npm run test' script has been removed from the 'scripts' section of the 'packages/@apphosting/build/package.json' file. This script previously invoked 'npm run test:functional'.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes the test script from the @apphosting/build package to, as the title suggests, unblock publishing. While this change will likely achieve that immediate goal, it comes at the cost of disabling the test suite for this package from being run as part of the repository's main test script. This introduces a risk of future regressions going undetected. My review raises this as a high-severity concern and suggests alternative approaches to consider for a more robust, long-term solution.

[gemini-code-assist]

Removing the test script will cause the top-level lerna run test command to skip running tests for this package. While this may be a necessary short-term fix to unblock publishing, it effectively disables a part of your test suite and increases the risk of introducing regressions.

Instead of removing the script, please consider one of these alternatives:

• Fix the underlying test failure: The best long-term solution is to investigate why test:functional is failing in the publishing pipeline and fix it.
• Temporarily skip tests: If the tests are flaky, they can be temporarily skipped within the test framework (e.g., using it.skip() in Mocha) with a TODO comment and a ticket to track the fix.
• Update the root test script: If these tests should not be run as part of the standard test run, consider modifying the root scripts/test.js to explicitly exclude this package, for example, by adding --ignore @apphosting/build to the lerna command.

Completely removing the test script should be a last resort. Could a follow-up task be created to address the underlying issue and re-enable these tests?