Skip to content

Remove npm run test script to unblock publishing #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2025
Merged

Remove npm run test script to unblock publishing #407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/@apphosting/build/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"sideEffects": false,
"scripts": {
"build": "rm -rf dist && tsc && chmod +x ./dist/bin/*",
"test": "npm run test:functional",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Removing the test script will cause the top-level lerna run test command to skip running tests for this package. While this may be a necessary short-term fix to unblock publishing, it effectively disables a part of your test suite and increases the risk of introducing regressions.

Instead of removing the script, please consider one of these alternatives:

  • Fix the underlying test failure: The best long-term solution is to investigate why test:functional is failing in the publishing pipeline and fix it.
  • Temporarily skip tests: If the tests are flaky, they can be temporarily skipped within the test framework (e.g., using it.skip() in Mocha) with a TODO comment and a ticket to track the fix.
  • Update the root test script: If these tests should not be run as part of the standard test run, consider modifying the root scripts/test.js to explicitly exclude this package, for example, by adding --ignore @apphosting/build to the lerna command.

Completely removing the test script should be a last resort. Could a follow-up task be created to address the underlying issue and re-enable these tests?

"test:functional": "node --loader ts-node/esm ./e2e/run-local-build.ts"
},
"exports": {
Expand Down