Fix processing of updates in MemberListState
#93
+77
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
3 tasks
There was a problem hiding this comment.
Pull Request Overview
Fixes MemberListState update logic to enforce sorting and to process added members during batch updates, ensuring member lists remain correctly ordered after add/update operations.
- Enforces sorted insertion/repositioning using upsertSorted and explicit sorting with CompositeComparator
- Processes added members in ModelUpdates (previously ignored) and updates tests to validate ordering and repositioning
- Refactors tests to use deterministic createdAt values and a helper for initial state setup
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| MemberListStateImpl.kt | Adds sorted upsert logic for single and batch updates; processes added members and re-sorts list |
| MemberListStateImplTest.kt | Updates/extends tests to cover sorting, added members in batch updates, and repositioning logic; adds helper |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.../src/test/kotlin/io/getstream/feeds/android/client/internal/state/MemberListStateImplTest.kt
Outdated
Show resolved
Hide resolved
...ient/src/main/kotlin/io/getstream/feeds/android/client/internal/state/MemberListStateImpl.kt
Show resolved
Hide resolved
SDK Size Comparison 📏
|
gpunto
force-pushed
the
fix/memberliststate-batch-updates
branch
from
39ebb32 to
26e47a0
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The current logic to add/update members into
MemberListStatehas two flaws:addedmembers on batch updatesThi PR fixes that.
Implementation
Handle
addedmembers for batch updates & enforce sortingTesting
Testing manually it's not trivial, but there are now unit tests exercising that behavior.
Checklist