Support ADTypes.NoAutoDiff #851
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #851 +/- ##
==========================================
- Coverage 98.10% 96.19% -1.92%
==========================================
Files 134 134
Lines 7986 7982 -4
==========================================
- Hits 7835 7678 -157
- Misses 151 304 +153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oschulz
force-pushed
the
no-auto-diff
branch
2 times, most recently
from
95ba522 to
7e44a45
Compare
|
@gdalle is this Ok like this? |
|
I fixed the Enzyme CI error, can you integrate the latest changes from |
oschulz
force-pushed
the
no-auto-diff
branch
from
7e44a45 to
3930398
Compare
Done now - is this Ok? |
|
Test failures are unrelated, right? |
gdalle
requested changes
Sep 18, 2025
| """ | ||
| check_inplace(backend) | ||
|
|
||
| Check whether `backend` supports differentiation of in-place functions and return a `Bool`. | ||
| """ | ||
| check_inplace(backend::AbstractADType) = Bool(inplace_support(backend)) | ||
|
|
||
| check_inplace(::ADTypes.NoAutoDiff) = throw(ADTypes.NoAutoDiffSelectedError()) |
There was a problem hiding this comment.
Could you put this one level higher, inside the inplace_support trait?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires SciML/ADTypes.jl#126