Skip to content

Support ADTypes.NoAutoDiff #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support ADTypes.NoAutoDiff #851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38a8858
Support ADTypes.NoAutoDiff
oschulz Sep 12, 2025
3930398
Require ADTypes v1.17 for NoAutoDiff
oschulz Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DifferentiationInterface/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ DifferentiationInterfaceTrackerExt = "Tracker"
DifferentiationInterfaceZygoteExt = ["Zygote", "ForwardDiff"]

[compat]
ADTypes = "1.17.0"
ADTypes = "1.18.0"
ChainRulesCore = "1.23.0"
DiffResults = "1.1.0"
Diffractor = "=0.2.6"
Expand Down
4 changes: 4 additions & 0 deletions DifferentiationInterface/src/utils/check.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,13 @@ function check_available(backend::MixedMode)
check_available(reverse_backend(backend))
end

check_available(::ADTypes.NoAutoDiff) = throw(ADTypes.NoAutoDiffSelectedError())

"""
check_inplace(backend)

Check whether `backend` supports differentiation of in-place functions and return a `Bool`.
"""
check_inplace(backend::AbstractADType) = Bool(inplace_support(backend))

check_inplace(::ADTypes.NoAutoDiff) = throw(ADTypes.NoAutoDiffSelectedError())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put this one level higher, inside the inplace_support trait?

3 changes: 3 additions & 0 deletions DifferentiationInterface/test/Core/ZeroBackends/test.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ using Test

LOGGING = get(ENV, "CI", "false") == "false"

@test_throws NoAutoDiffSelectedError check_available(NoAutoDiff())
@test_throws NoAutoDiffSelectedError check_inplace(NoAutoDiff())

zero_backends = [AutoZeroForward(), AutoZeroReverse()]

for backend in zero_backends
Expand Down
Loading