Skip to content

graphql-language-service-cli: init at 3.5.0 #384397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

nathanregner
Copy link
Contributor

@nathanregner nathanregner commented Feb 23, 2025

Previously packaged by node2nix, removed in 776868c/#382557 due to build breakage

Fixes #390063

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 3, 2025
Copy link
Member

@ethancedwards8 ethancedwards8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. Nice work. Neat package.

@nathanregner nathanregner force-pushed the graphql-language-service-cli branch from 53beb45 to f540eb4 Compare March 8, 2025 06:00
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Mar 8, 2025
@FliegendeWurst FliegendeWurst added the 8.has: package (new) This PR adds a new package label Mar 15, 2025
@nathanregner nathanregner force-pushed the graphql-language-service-cli branch 2 times, most recently from 6746820 to 48ede22 Compare March 15, 2025 16:57
@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Mar 15, 2025
@nathanregner nathanregner force-pushed the graphql-language-service-cli branch from 48ede22 to 626f41f Compare March 15, 2025 22:20
@dotlambda
Copy link
Member

We could add nodePackages.graphql-language-service-cli as an alias: #390063

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the alias from dotlambda

Previously packaged by `node2nix`, removed in 776868c
@nathanregner nathanregner force-pushed the graphql-language-service-cli branch from 626f41f to d872a2a Compare March 17, 2025 22:32
@dotlambda dotlambda merged commit 5996243 into NixOS:master Mar 17, 2025
25 of 27 checks passed
xav-ie added a commit to xav-ie/xnixvim that referenced this pull request Mar 31, 2025
xav-ie added a commit to xav-ie/xnixvim that referenced this pull request May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nodePackages.graphql-language-service-cli Missing from nixos-unstable
6 participants