Add Kashmiri Language Localization and Improve Related Documentation #1057
Conversation
|
Warning Rate limit exceeded@mirnumaan has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 14 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Summary by CodeRabbit
WalkthroughAdds a new Kashmiri locale file Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
nettacker/locale/ka.yml (1)
1-123: Fix YAML syntax in nettacker/locale/ka.ymlYAML parser fails at line 34, column 66 with “mapping values are not allowed here.” Quote or escape the offending colons/special characters to produce valid YAML, then re-run your placeholder-parity and key-presence checks.
🧹 Nitpick comments (1)
nettacker/locale/ka.yml (1)
60-60: Quote URLs for consistency and future-proofing.Not required syntactically here, but quoting avoids accidental parse issues if the line changes.
-license: "براہِ کرم لائسنس تہ معاہدہ پڑھو https://github.com/OWASP/Nettacker" +license: "براہِ کرم لائسنس تہ معاہدہ پڑھو https://github.com/OWASP/Nettacker" # (No content change; leave as-is if project style prefers unquoted. This is a heads-up.)
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
nettacker/locale/ka.yml(1 hunks)
🧰 Additional context used
🪛 Checkov (3.2.334)
nettacker/locale/ka.yml
[MEDIUM] 68-69: Basic Auth Credentials
(CKV_SECRET_4)
🪛 YAMLlint (1.37.1)
nettacker/locale/ka.yml
[error] 99-99: trailing spaces
(trailing-spaces)
[error] 100-100: trailing spaces
(trailing-spaces)
[error] 34-34: syntax error: mapping values are not allowed here
(syntax)
🔇 Additional comments (2)
nettacker/locale/ka.yml (2)
87-90: YAML “\n” escapes become real newlines—verify downstream formatting
Per the YAML spec, double-quoted"\n"is parsed into actual newline characters, not literal\+n. Confirm that your logging/formatter correctly handles these embedded newlines for the messages in nettacker/locale/ka.yml (lines 87–90).
1-3: Rename locale code from “ka” to “ks”
The file nettacker/locale/ka.yml must be renamed to nettacker/locale/ks.yml (or a BCP-47 tag like ks-Arab.yml). No code references to “ka” locales were found in loader or app code—locale files are auto-discovered by filename—so no further changes are required.
arkid15r
left a comment
arkid15r
left a comment
There was a problem hiding this comment.
Hi @mirnumaan
Thanks for the l10n contribution! Could you address the suggestions and fix the pre-commit?
Thank you!
There was a problem hiding this comment.
Pull Request Overview
This pull request adds Kashmiri language localization support to the OWASP Nettacker project, enabling Kashmiri-speaking users to interact with the tool in their native language.
- Adds a new Kashmiri (ka) locale file with 119 translated strings
- Includes translations for API options, scan methods, error messages, and user interface elements
- Extends the project's multilingual capabilities alongside existing 24+ language support
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
nettacker/locale/ka.yml(1 hunks)
🧰 Additional context used
🪛 Checkov (3.2.334)
nettacker/locale/ka.yml
[medium] 67-68: Basic Auth Credentials
(CKV_SECRET_4)
🪛 YAMLlint (1.37.1)
nettacker/locale/ka.yml
[error] 34-34: syntax error: expected , but found ''
(syntax)
🔇 Additional comments (3)
nettacker/locale/ka.yml (3)
67-67: Credentials masking appears correct; verify static analysis false positive is resolved.The credentials in the example are masked as
USERNAME:PASSWORDto avoid triggering secret scanners. This aligns with the prior review feedback. However, the static analysis tool still flags lines 67–68 with CKV_SECRET_4. After merging and running the full CI pipeline, confirm that this false positive is suppressed or that linting rules are satisfied.
98-98: Multiline formatting appears resolved.Line 98 is now a properly formatted single-line value for
start_parallel_module_scan. The prior review flagged lines 99–101 for multiline issues and trailing spaces; those appear to have been corrected.
28-28: YAML parsing ambiguity resolved.Line 28's value is properly quoted, preserving the ellipsis and brackets as a literal string. No parsing ambiguity.
|
Kindly review the fixes I have made, thank you |
2 participants
Proposed change
This pull request adds Kashmiri language localization support to the OWASP Nettacker project. All user-facing strings have been translated, allowing Kashmiri-speaking users to better understand and interact with the tool.
Type of change
Checklist
make pre-commit, it didn't generate any changesmake test, all tests passed locally