-
-
Notifications
You must be signed in to change notification settings - Fork 68
Humemah Add Set Final Day permission functionality #3991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
humemah
wants to merge
14
commits into
development
Choose a base branch
from
Humemah-Updated-final-day
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+90
−21
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
52332f0
Add Set Final Day permission functionality
humemah 0c677f8
resolve merge conflicts'
humemah 72639a8
Fix merge conflicts
humemah eb6904d
humemah: Resolve merge conflicts
humemah ea8020a
humemah: Resolved merge conflicts
humemah 1e6a2ec
humemah: Resolved merge conflicts
humemah 8bc971d
humemah: Resolved merge conflicts
humemah a4bf300
humemah: Resolved merge conflicts
humemah 4d6f922
humemah: Resolved merge conflicts
humemah 3ac02dd
humemah: Resolved merge conflicts
humemah bb4f095
humemah: Resolved merge conflicts
humemah 8faff48
humemah: update
humemah a513d70
humemah: update
humemah 273873b
humemah: update
humemah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From PR#3245. The route permissions also need to be updated as in that PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the permission Set Final Day for User is already defined in PermissionsConst.jsx
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The key for that is
'setUserFinalDay'instead of'setFinalDay'as you're checking. So the key needs to be updated either in yourhasPermission()calls or in PermissionsConst and anywhere that actually uses'setUserFinalDay'.This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.