Humemah Add Set Final Day permission functionality #3991
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Updated src/components/PermissionsManagement/PermissionsConst.jsx - Added new "Set Final Day" permission definition
Where? Looks like this still needs to be done.
There was a problem hiding this comment.
From PR#3245. The route permissions also need to be updated as in that PR.
{
label: 'Set Final Day',
key: 'setFinalDay',
description: 'Gives the user permission to set the final working day.',
},
There was a problem hiding this comment.
the permission Set Final Day for User is already defined in PermissionsConst.jsx
There was a problem hiding this comment.
The key for that is 'setUserFinalDay' instead of 'setFinalDay' as you're checking. So the key needs to be updated either in your hasPermission() calls or in PermissionsConst and anywhere that actually uses 'setUserFinalDay'.
There was a problem hiding this comment.
Then the permission checks are inverted, which probably looks like it's working because it's checking the wrong value.
| {!isCurrentUser && ( | ||
| <> | ||
| {!canChangeUserStatus ? ( | ||
| {!canSetFinalDay ? ( |
There was a problem hiding this comment.
| {!canSetFinalDay ? ( | |
| {canChangeUserStatus || canSetFinalDay ? ( |
or
| {!canSetFinalDay ? ( | |
| {canSetFinalDay ? ( |
- It looks like the logic for this is inverted? (with the '!')
- Should
changeUserStatusalso be controlling this, or should it be fully replaced?
There was a problem hiding this comment.
Tested PR locally. Performed check by enabling users with permissions to set final day. Works as expected.
Admin able to set final day for self
Admin able to set final day for other account:
User with permission able to set final day:
User without permission cannot see the set final day button.
ShradhaMBhadrannavar
left a comment
ShradhaMBhadrannavar
left a comment
There was a problem hiding this comment.
I tried testing this PR locally multiple times but encountered the error shown in the attached screenshot. I followed all the steps mentioned in the “How to Test” section, but the issue persists. Could you please check if there’s something I might be missing or any additional setup required?
one-community
added
the
High Priority - Please Review First
|
Tested this PR with the latest |
|
Hello, |
Thanks for noticing! The tooltip shows a minor UI mismatch, but the button works correctly for Admins. |
Thanks for checking! Based on the error message, it looks like a local environment issue rather than a problem with the PR itself. |
|
Hi Humemah, |
|
Tested this PR locally and followed the provided test instructions. |
|
Description
Related PRS (if any):
This frontend PR is related to the #3245
Main changes explained:
Updated src/components/Header/Header.jsx - Added setFinalDay permission to user management access check
Updated src/components/UserManagement/UserTableData.jsx - Added SetFinalDayButton component with permission check
Updated src/components/UserProfile/BasicInformationTab/BasicInformationTab.jsx - Added button visibility based on permission
How to test:
Check out this branch: git checkout Humemah-Updated-final-day
Run npm install and npm start to run locally
Clear site data/cache
Log in as admin/owner user
Go to → Other Links → Permission Management → User Roles
Verify that only Owner and Admin users have this permission by default
Go to → Other Links → Permission Management → Manage User Permission
Verify the permission can be added to other users that are not Admin nor Owner
Go to any user's Profile → Basic Information → End Date section
Verify users with permission can see and interact with the "Set Final Day" button
Verify users without permission cannot see the button
Screenshots or videos of changes:
Note:
Include the information the reviewers need to know.